kiwitcms/Kiwi

View on GitHub

Showing 243 of 379 total issues

Element (p.errornote) is overqualified, just use .errornote without element name.
Open

.errorlist, p.errornote + ul.errorlist,

Element (header#grp-header) is overqualified, just use #grp-header without element name.
Open

header#grp-header { position: static; }
Severity: Minor
Found in tcms/static/style/admin.css by csslint

Don't use IDs in selectors.
Open

#grp-content { top: 0; }
Severity: Minor
Found in tcms/static/style/admin.css by csslint

Don't use IDs in selectors.
Open

aside div#search { width: 200px; }
Severity: Minor
Found in tcms/static/style/admin.css by csslint

Adjoining classes: .tt-suggestion.tt-cursor
Open

.tt-suggestion.tt-cursor {

Expected COLON at line 72, col 26.
Open

    color: #c00; inherit !important;

Don't use IDs in selectors.
Open

header#grp-header { position: static; }
Severity: Minor
Found in tcms/static/style/admin.css by csslint

Element (a.no-before::before) is overqualified, just use .no-before without element name.
Open

.panel-group .panel-title > a.no-before::before {

Using width with padding-left can sometimes make elements larger than you expect.
Open

    padding-left: 1px;

Use of !important
Open

        display: none !important;

Element (nav.navbar-default) is overqualified, just use .navbar-default without element name.
Open

nav.navbar-default { border-top-color: #3C8D2C; }

Rename function "makeExtension" to match the regular expression ^[a-z_][a-z0-9_]{2,}$.
Open

def makeExtension(**kwargs):  # pylint: disable=invalid-name
Severity: Major
Found in tcms/utils/markdown.py by sonar-python

Shared coding conventions allow teams to collaborate efficiently. This rule checks that all function names match a provided regular expression.

Noncompliant Code Example

With the default provided regular expression: ^[a-z_][a-z0-9_]{2,30}$

def MyFunction(a,b):
    ...

Compliant Solution

def my_function(a,b):
    ...

TODO found
Open

    // TODO: remove the page reload above and add the new case to the list

TODO found
Open

      // TODO: figure out how to reload above and add the new value to the page
Severity: Minor
Found in tcms/static/js/utils.js by fixme

TODO found
Open

// TODO: this entire file is mostly duplicate with testplans/js/mutable.js
Severity: Minor
Found in tcms/bugs/static/bugs/js/mutable.js by fixme

Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.
Open

    def clean(self, value):
Severity: Critical
Found in tcms/core/forms/fields.py by sonar-python

Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

See

Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed.
Open

def update(
Severity: Critical
Found in tcms/rpc/api/user.py by sonar-python

Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

See

Merge this if statement with the enclosing one.
Open

        if (not os.path.exists(filename)) or (not read_installation_id(filename)):
Severity: Major
Found in tcms/core/checks.py by sonar-python

Merging collapsible if statements increases the code's readability.

Noncompliant Code Example

if condition1:
    if condition2:
        # ...

Compliant Solution

if condition1 and condition2:
    # ...

BUG found
Open

        keeping a reference to BUG-ID and trying to reconstruct the URL
Severity: Minor
Found in CHANGELOG.rst by fixme

TODO found
Open

// TODO: this can be moved to the back-end and provide the percentage there
Severity
Category
Status
Source
Language