Sign upLogin

koraktor/gallerist

View on GitHub
Star

Showing 604 of 604 total issues

Missing top-level module documentation comment.
Open

module Gallerist::Logging
Severity: Minor
Found in lib/gallerist/logging.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use nested module/class definitions instead of compact style.
Open

module Gallerist::Logging
Severity: Minor
Found in lib/gallerist/logging.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Use the return of the conditional for variable assignment and comparison.
Open

    if photo.thumbnail_available?
      thumbnail_path = photo.small_thumbnail_path
    else
      thumbnail_path = photo.preview_path
    end
Severity: Minor
Found in lib/gallerist/app.rb by rubocop

Align the parameters of a method call if they span more than one line.
Open

      disposition: :inline,
      filename: "preview_#{photo.file_name}"
Severity: Minor
Found in lib/gallerist/app.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Extra empty line detected at block body beginning.
Open


    before do
Severity: Minor
Found in spec/gallerist/library_spec.rb by rubocop

This cops checks if empty lines around the bodies of blocks match the configuration.

Example: EnforcedStyle: empty_lines

# good

foo do |bar|

  # ...

end

Example: EnforcedStyle: noemptylines (default)

# good

foo do |bar|
  # ...
end

Missing top-level class documentation comment.
Open

class Gallerist::MultiTag
Severity: Minor
Found in lib/gallerist/multi_tag.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Extra empty line detected at block body end.
Open


  end
Severity: Minor
Found in spec/gallerist/library_spec.rb by rubocop

This cops checks if empty lines around the bodies of blocks match the configuration.

Example: EnforcedStyle: empty_lines

# good

foo do |bar|

  # ...

end

Example: EnforcedStyle: noemptylines (default)

# good

foo do |bar|
  # ...
end

Align .where with .photos on line 19.
Open

            .where(RKKeywordForVersion: { keywordId: @tags.map(&:id) })
Severity: Minor
Found in lib/gallerist/multi_tag.rb by rubocop

This cop checks the indentation of the method name part in method calls that span more than one line.

Example: EnforcedStyle: aligned

# bad
while myvariable
.b
  # do something
end

# good
while myvariable
      .b
  # do something
end

# good
Thing.a
     .b
     .c

Example: EnforcedStyle: indented

# good
while myvariable
  .b

  # do something
end

Example: EnforcedStyle: indentedrelativeto_receiver

# good
while myvariable
        .a
        .b

  # do something
end

# good
myvariable = Thing
               .a
               .b
               .c

Line is too long. [93/80]
Open

    expect(library.inspect).to eq("#<Gallerist::Library path='/some/library.photoslibrary'>")
Severity: Minor
Found in spec/gallerist/library_spec.rb by rubocop

Do not use space inside array brackets.
Open

      receive(:pluck).with(:propertyValue).and_return [ 'com.apple.Photos' ]
Severity: Minor
Found in spec/gallerist/library_spec.rb by rubocop

Checks that brackets used for array literals have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: space

# The `space` style enforces that array literals have
# surrounding space.

# bad
array = [a, b, c, d]

# good
array = [ a, b, c, d ]

Example: EnforcedStyle: no_space

# The `no_space` style enforces that array literals have
# no surrounding space.

# bad
array = [ a, b, c, d ]

# good
array = [a, b, c, d]

Example: EnforcedStyle: compact

# The `compact` style normally requires a space inside
# array brackets, with the exception that successive left
# or right brackets are collapsed together in nested arrays.

# bad
array = [ a, [ b, c ] ]

# good
array = [ a, [ b, c ]]

Extra empty line detected at block body beginning.
Open


  let(:library) { double }
Severity: Minor
Found in spec/gallerist/multi_tag_spec.rb by rubocop

This cops checks if empty lines around the bodies of blocks match the configuration.

Example: EnforcedStyle: empty_lines

# good

foo do |bar|

  # ...

end

Example: EnforcedStyle: noemptylines (default)

# good

foo do |bar|
  # ...
end

Align .group with .where on line 25.
Open

              .group(:versionId)
Severity: Minor
Found in lib/gallerist/multi_tag.rb by rubocop

This cop checks the indentation of the method name part in method calls that span more than one line.

Example: EnforcedStyle: aligned

# bad
while myvariable
.b
  # do something
end

# good
while myvariable
      .b
  # do something
end

# good
Thing.a
     .b
     .c

Example: EnforcedStyle: indented

# good
while myvariable
  .b

  # do something
end

Example: EnforcedStyle: indentedrelativeto_receiver

# good
while myvariable
        .a
        .b

  # do something
end

# good
myvariable = Thing
               .a
               .b
               .c

0.6 should be written without a leading zero as .6
Open

    opacity: 0.6;
Severity: Minor
Found in assets/stylesheets/main.scss by scss-lint

0.3 should be written without a leading zero as .3
Open

      @include transition(text-shadow 0.3s);
Severity: Minor
Found in assets/stylesheets/main.scss by scss-lint

Colon after property should be followed by one space
Open

        text-shadow:  2px  2px 0 $btn-info-bg,
Severity: Minor
Found in assets/stylesheets/main.scss by scss-lint

Extra empty line detected at block body beginning.
Open


    before do
Severity: Minor
Found in spec/gallerist/library_spec.rb by rubocop

This cops checks if empty lines around the bodies of blocks match the configuration.

Example: EnforcedStyle: empty_lines

# good

foo do |bar|

  # ...

end

Example: EnforcedStyle: noemptylines (default)

# good

foo do |bar|
  # ...
end

Line is too long. [109/80]
Open

      receive(:where).with(propertyArea: 'database', propertyName: 'applicationIdentifier').and_return app_id
Severity: Minor
Found in spec/gallerist/library_spec.rb by rubocop

Each selector in a comma sequence should be on its own single line
Open

    .modal-next, .modal-prev {
Severity: Minor
Found in assets/stylesheets/main.scss by scss-lint

Each selector in a comma sequence should be on its own single line
Open

    .view-container, img, video {
Severity: Minor
Found in assets/stylesheets/main.scss by scss-lint

Do not use space inside array brackets.
Open

      receive(:pluck).with(:propertyValue).and_return [ 'com.apple.Photos' ]
Severity: Minor
Found in spec/gallerist/library_spec.rb by rubocop

Checks that brackets used for array literals have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: space

# The `space` style enforces that array literals have
# surrounding space.

# bad
array = [a, b, c, d]

# good
array = [ a, b, c, d ]

Example: EnforcedStyle: no_space

# The `no_space` style enforces that array literals have
# no surrounding space.

# bad
array = [ a, b, c, d ]

# good
array = [a, b, c, d]

Example: EnforcedStyle: compact

# The `compact` style normally requires a space inside
# array brackets, with the exception that successive left
# or right brackets are collapsed together in nested arrays.

# bad
array = [ a, [ b, c ] ]

# good
array = [ a, [ b, c ]]
Severity
Category
Status
Source
Language