Sign upLogin

koraktor/gallerist

View on GitHub
Star

Showing 604 of 604 total issues

Colon after property should be followed by one space
Open

    text-shadow:  1px  1px 1px $label-color,
Severity: Minor
Found in assets/stylesheets/main.scss by scss-lint

Expected item on line 207 to appear before line 206. Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets
Open

    @include transition(background-color 0.2s ease-in-out, border 0.2s ease-in-out, opacity .15s linear);
Severity: Minor
Found in assets/stylesheets/main.scss by scss-lint

Extra empty line detected at block body beginning.
Open


    let(:all_tagged_photos) { double }
Severity: Minor
Found in spec/gallerist/multi_tag_spec.rb by rubocop

This cops checks if empty lines around the bodies of blocks match the configuration.

Example: EnforcedStyle: empty_lines

# good

foo do |bar|

  # ...

end

Example: EnforcedStyle: noemptylines (default)

# good

foo do |bar|
  # ...
end

Extra empty line detected at block body end.
Open


  end
Severity: Minor
Found in spec/gallerist/multi_tag_spec.rb by rubocop

This cops checks if empty lines around the bodies of blocks match the configuration.

Example: EnforcedStyle: empty_lines

# good

foo do |bar|

  # ...

end

Example: EnforcedStyle: noemptylines (default)

# good

foo do |bar|
  # ...
end

Add parentheses to nested method call library.file '/some', 'file'.
Open

      expect(library.file '/some', 'file').to eq('/some/file')
Severity: Minor
Found in spec/gallerist/library_spec.rb by rubocop

This cop checks for unparenthesized method calls in the argument list of a parenthesized method call.

Example:

# good
method1(method2(arg), method3(arg))

# bad
method1(method2 arg, method3, arg)

Do not use space inside array brackets.
Open

  s.authors     = [ 'Sebastian Staudt' ]
Severity: Minor
Found in gallerist.gemspec by rubocop

Checks that brackets used for array literals have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: space

# The `space` style enforces that array literals have
# surrounding space.

# bad
array = [a, b, c, d]

# good
array = [ a, b, c, d ]

Example: EnforcedStyle: no_space

# The `no_space` style enforces that array literals have
# no surrounding space.

# bad
array = [ a, b, c, d ]

# good
array = [a, b, c, d]

Example: EnforcedStyle: compact

# The `compact` style normally requires a space inside
# array brackets, with the exception that successive left
# or right brackets are collapsed together in nested arrays.

# bad
array = [ a, [ b, c ] ]

# good
array = [ a, [ b, c ]]

Do not use space inside array brackets.
Open

    allow(tag_photos).to receive(:where).with(RKKeywordForVersion: { keywordId: [ tag1.id, tag2.id ] }) do
Severity: Minor
Found in spec/gallerist/multi_tag_spec.rb by rubocop

Checks that brackets used for array literals have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: space

# The `space` style enforces that array literals have
# surrounding space.

# bad
array = [a, b, c, d]

# good
array = [ a, b, c, d ]

Example: EnforcedStyle: no_space

# The `no_space` style enforces that array literals have
# no surrounding space.

# bad
array = [ a, b, c, d ]

# good
array = [a, b, c, d]

Example: EnforcedStyle: compact

# The `compact` style normally requires a space inside
# array brackets, with the exception that successive left
# or right brackets are collapsed together in nested arrays.

# bad
array = [ a, [ b, c ] ]

# good
array = [ a, [ b, c ]]

0.5 should be written without a leading zero as .5
Open

      padding: 0.5em 0.5em 0 0.5em;
Severity: Minor
Found in assets/stylesheets/main.scss by scss-lint

Do not use space inside array brackets.
Open

  s.email       = [ 'koraktor@gmail.com' ]
Severity: Minor
Found in gallerist.gemspec by rubocop

Checks that brackets used for array literals have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: space

# The `space` style enforces that array literals have
# surrounding space.

# bad
array = [a, b, c, d]

# good
array = [ a, b, c, d ]

Example: EnforcedStyle: no_space

# The `no_space` style enforces that array literals have
# no surrounding space.

# bad
array = [ a, b, c, d ]

# good
array = [a, b, c, d]

Example: EnforcedStyle: compact

# The `compact` style normally requires a space inside
# array brackets, with the exception that successive left
# or right brackets are collapsed together in nested arrays.

# bad
array = [ a, [ b, c ] ]

# good
array = [ a, [ b, c ]]

0.2 should be written without a leading zero as .2
Open

    @include transition-delay(0.2s);
Severity: Minor
Found in assets/stylesheets/main.scss by scss-lint

Nesting should be no greater than 3, but was 4
Open

      .fa-stack-1x {
Severity: Minor
Found in assets/stylesheets/main.scss by scss-lint

Expected item on line 86 to appear before line 80. Rule sets should be ordered as follows: @extends, @includes without @content, properties, @includes with @content, nested rule sets
Open

    @include transition(left 0.5s ease-in-out);
Severity: Minor
Found in assets/stylesheets/main.scss by scss-lint

0.2 should be written without a leading zero as .2
Open

    @include transition(color 0.2s ease-in-out);
Severity: Minor
Found in assets/stylesheets/main.scss by scss-lint

0.2 should be written without a leading zero as .2
Open

  @include transition(background-color 0.2s ease-in-out);
Severity: Minor
Found in assets/stylesheets/main.scss by scss-lint

Properties should be ordered max-height, max-width
Open

    max-width: 100%;
Severity: Minor
Found in assets/stylesheets/main.scss by scss-lint

Use the lambda method for multiline lambdas.
Open

    scope :movies, -> {
Severity: Minor
Found in lib/gallerist/models/iphoto_extensions/photo.rb by rubocop

This cop (by default) checks for uses of the lambda literal syntax for single line lambdas, and the method call syntax for multiline lambdas. It is configurable to enforce one of the styles for both single line and multiline lambdas as well.

Example: EnforcedStyle: linecountdependent (default)

# bad
f = lambda { |x| x }
f = ->(x) do
      x
    end

# good
f = ->(x) { x }
f = lambda do |x|
      x
    end

Example: EnforcedStyle: lambda

# bad
f = ->(x) { x }
f = ->(x) do
      x
    end

# good
f = lambda { |x| x }
f = lambda do |x|
      x
    end

Example: EnforcedStyle: literal

# bad
f = lambda { |x| x }
f = lambda do |x|
      x
    end

# good
f = ->(x) { x }
f = ->(x) do
      x
    end

include is used at the top level. Use inside class or module.
Open

include Gallerist
Severity: Minor
Found in spec/spec_helper.rb by rubocop

This cop checks that include, extend and prepend exists at the top level. Using these at the top level affects the behavior of Object. There will not be using include, extend and prepend at the top level. Let's use it inside class or module.

Example:

# bad
include M

class C
end

# bad
extend M

class C
end

# bad
prepend M

class C
end

# good
class C
  include M
end

# good
class C
  extend M
end

# good
class C
  prepend M
end

Line is too long. [115/80]
Open

      allow(tagged_photos).to receive(:where).with(RKKeywordForVersion: { modelId: unique_tags }) { tagged_photos }
Severity: Minor
Found in spec/gallerist/multi_tag_spec.rb by rubocop

Do not use space inside array brackets.
Open

  s.authors     = [ 'Sebastian Staudt' ]
Severity: Minor
Found in gallerist.gemspec by rubocop

Checks that brackets used for array literals have or don't have surrounding space depending on configuration.

Example: EnforcedStyle: space

# The `space` style enforces that array literals have
# surrounding space.

# bad
array = [a, b, c, d]

# good
array = [ a, b, c, d ]

Example: EnforcedStyle: no_space

# The `no_space` style enforces that array literals have
# no surrounding space.

# bad
array = [ a, b, c, d ]

# good
array = [a, b, c, d]

Example: EnforcedStyle: compact

# The `compact` style normally requires a space inside
# array brackets, with the exception that successive left
# or right brackets are collapsed together in nested arrays.

# bad
array = [ a, [ b, c ] ]

# good
array = [ a, [ b, c ]]

Avoid using id selectors
Open

#photo-modal {
Severity: Minor
Found in assets/stylesheets/main.scss by scss-lint
Severity
Category
Status
Source
Language