Sign upLogin

krateng/maloja

View on GitHub
Star

Showing 192 of 192 total issues

Function scrobble has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function scrobble(artists,title,albumartists,album,timestamp) {
Severity: Minor
Found in maloja/web/static/js/manualscrobble.js - About 35 mins to fix

    Function wrapper has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def wrapper(*args,k_filter, k_limit, k_delimit, k_amount):
    Severity: Minor
    Found in maloja/apis/native_v1.py - About 35 mins to fix

      Function incoming_scrobble has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def incoming_scrobble(rawscrobble,fix=True,client=None,api=None,dbconn=None):
      Severity: Minor
      Found in maloja/database/__init__.py - About 35 mins to fix

        Function startPlayback has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            startPlayback(artist,title,seconds) {

        // CASE 1: Resuming playback of previously played title
        if (artist == this.currentArtist && title == this.currentTitle && !this.currentlyPlaying) {
            console.log("Resuming playback of " + this.currentTitle)
        Severity: Minor
        Found in auxiliary/chromium_scrobbler/maloja-scrobbler/background.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_top_tracks has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def get_top_tracks(dbconn=None,compatibility=True,**keys):

    rngs = ranges(**{k:keys[k] for k in keys if k in ["since","to","within","timerange","step","stepn","trail"]})
    results = []
        Severity: Minor
        Found in maloja/database/__init__.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function cached_wrapper has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def cached_wrapper(inner_func):

        def outer_func(*args,**kwargs):

            if 'dbconn' in kwargs:
        Severity: Minor
        Found in maloja/database/dbcache.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function authorize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def authorize(self):

        if self.active_metadata():

            try:
        Severity: Minor
        Found in maloja/thirdparty/spotify.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function wrapper has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def wrapper(self,path:Multi=[],**keys):
        log(f"{self.__apiname__} API request: {path}")# + " | Keys: " + str({k:keys.get(k) for k in keys}))

        try:
            response.status,result = self.handle(path,keys)
        Severity: Minor
        Found in maloja/apis/_base.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function __init_subclass__ has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def __init_subclass__(cls,abstract=False):
        if not abstract:
            s = cls()
            if s.active_proxyscrobble():
                services["proxyscrobble"].append(s)
        Severity: Minor
        Found in maloja/thirdparty/__init__.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function scrobbleNew has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        function scrobbleNew() {
    var artistnodes = document.getElementById("artists_td").getElementsByTagName("span");
    var artists = [];
    for (let node of artistnodes) {
        artists.push(node.textContent);
        Severity: Minor
        Found in maloja/web/static/js/manualscrobble.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function onInternalMessage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        function onInternalMessage(request,sender) {
    if (request.type == "response") {
        players = request.content
        html = "";
        for (var i=0;i<players.length;i++) {
        Severity: Minor
        Found in auxiliary/chromium_scrobbler/maloja-scrobbler/settings.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function parse_maloja has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def parse_maloja(inputf):

    with open(inputf,'r') as inputfd:
        data = json.load(inputfd)
        Severity: Minor
        Found in maloja/proccontrol/tasks/import_scrobbles.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function contextual_desc has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def contextual_desc(self,other):
        # TODO: more elegant maybe?
        if not isinstance(other, MTRangeGregorian): return self.desc()

        relevant = self.desc().split(" ")
        Severity: Minor
        Found in maloja/malojatime.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function parse_lastfm has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def parse_lastfm(inputf):

    with open(inputf,'r',newline='') as inputfd:
        reader = csv.reader(inputfd)
        Severity: Minor
        Found in maloja/proccontrol/tasks/import_scrobbles.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_top_albums has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def get_top_albums(dbconn=None,compatibility=True,**keys):

    rngs = ranges(**{k:keys[k] for k in keys if k in ["since","to","within","timerange","step","stepn","trail"]})
    results = []
        Severity: Minor
        Found in maloja/database/__init__.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function toggleAssociationIcons has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        function toggleAssociationIcons(element) {
    var entity_type = element.dataset.entity_type;
    var entity_id = element.dataset.entity_id;
    entity_id = parseInt(entity_id);
        Severity: Minor
        Found in maloja/web/static/js/edit.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function desc has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def desc(self,prefix=False):
        if self.since is not None and self.to is not None:
            if prefix:
                return f"from {self.since.contextual_desc(self.to)} to {self.to.desc()}"
            else:
        Severity: Minor
        Found in maloja/malojatime.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function incoming_scrobble has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def incoming_scrobble(rawscrobble,fix=True,client=None,api=None,dbconn=None):

    missing = []
    for necessary_arg in ["track_artists","track_title"]:
        if not necessary_arg in rawscrobble or len(rawscrobble[necessary_arg]) == 0:
        Severity: Minor
        Found in maloja/database/__init__.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_top_artists has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def get_top_artists(dbconn=None,compatibility=True,**keys):

    separate = keys.get('separate')

    rngs = ranges(**{k:keys[k] for k in keys if k in ["since","to","within","timerange","step","stepn","trail"]})
        Severity: Minor
        Found in maloja/database/__init__.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        return self.parseArtists(re.sub(r"(.*) [\(\[]" + d + " (.*)[\)\]]",r"\1",a,flags=re.IGNORECASE)) + \
                        self.parseArtists(re.sub(r"(.*) [\(\[]" + d + " (.*)[\)\]]",r"\2",a,flags=re.IGNORECASE))
        Severity: Minor
        Found in maloja/cleanup.py and 1 other location - About 35 mins to fix
        maloja/cleanup.py on lines 116..116

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 33.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language