Sign upLogin

krateng/maloja

View on GitHub
Star

Showing 192 of 192 total issues

Avoid too many return statements within this function.
Open

        return [a.strip()]
Severity: Major
Found in maloja/cleanup.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return self.rules_replaceartist[a.strip().lower()].split("␟")
    Severity: Major
    Found in maloja/cleanup.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return self.parseArtists(re.sub(r"(.*) [\(\[]" + d + " (.*)[\)\]]",r"\1",a,flags=re.IGNORECASE)) + \
      Severity: Major
      Found in maloja/cleanup.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return [a.strip()]
        Severity: Major
        Found in maloja/cleanup.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return []
          Severity: Major
          Found in maloja/cleanup.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return ls
            Severity: Major
            Found in maloja/cleanup.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return ""
              Severity: Major
              Found in maloja/malojatime.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return ls
                Severity: Major
                Found in maloja/cleanup.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return json.dumps(obj.hashable())
                  Severity: Major
                  Found in maloja/database/dbcache.py - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        for (var i=0;i<reactivate.length;i++) {
        reactivate[i].setAttribute("style","");
    }
                    Severity: Minor
                    Found in maloja/web/static/js/statselect.js and 1 other location - About 30 mins to fix
                    maloja/web/static/js/statselect.js on lines 21..23

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        for (var i=0;i<selectors.length;i++) {
        selectors[i].setAttribute("style","");
    }
                    Severity: Minor
                    Found in maloja/web/static/js/statselect.js and 1 other location - About 30 mins to fix
                    maloja/web/static/js/statselect.js on lines 15..17

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Avoid too many return statements within this function.
                    Open

                                return self.parseArtists(re.split(" [Pp]erforming",a)[0])
                    Severity: Major
                    Found in maloja/cleanup.py - About 30 mins to fix

                      Function get_image_from_cache has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      def get_image_from_cache(track_id=None,artist_id=None,album_id=None):
    now = int(datetime.datetime.now().timestamp())
    entity_id, table = get_id_and_table(track_id=track_id,artist_id=artist_id,album_id=album_id)

    with engine.begin() as conn:
                      Severity: Minor
                      Found in maloja/images.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function createCheckmarks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function createCheckmarks() {
    if (this.readyState == 4) {
        if ((this.status >= 200) && (this.status < 300)) {
            //document.getElementById("checkmark_url").innerHTML = "✔️"
            //document.getElementById("checkmark_key").innerHTML = "✔️"
                      Severity: Minor
                      Found in auxiliary/chromium_scrobbler/maloja-scrobbler/settings.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function ranges has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      def ranges(since=None,to=None,within=None,timerange=None,step="month",stepn=1,trail=1,max_=None):

    (firstincluded,lastincluded) = time_stamps(since=since,to=to,within=within,range=timerange)

    d_start = from_timestamp(firstincluded,step)
                      Severity: Minor
                      Found in maloja/malojatime.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function get_scrobbles_of_album has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      def get_scrobbles_of_album(album,since=None,to=None,resolve_references=True,limit=None,reverse=False,dbconn=None):

    if since is None: since=0
    if to is None: to=now()
                      Severity: Minor
                      Found in maloja/database/sqldb.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function get_associated_artist_map has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      def get_associated_artist_map(artists=[],artist_ids=None,resolve_ids=True,dbconn=None):

    ids_supplied = (artist_ids is not None)

    if not ids_supplied:
                      Severity: Minor
                      Found in maloja/database/sqldb.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function run_supervisor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      def run_supervisor():
    setproctitle("maloja_supervisor")
    while True:
        log("Maloja is not running, starting...",module="supervisor")
        try:
                      Severity: Minor
                      Found in maloja/__main__.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function get_token_from_request_keys has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def get_token_from_request_keys(self,keys):
        if 'token' in keys:
            return keys.get("token").strip()
        if 'Authorization' in keys:
            auth = keys.get("Authorization")
                      Severity: Minor
                      Found in maloja/apis/listenbrainz.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function get_track_image has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      def get_track_image(track=None,track_id=None):
    if track_id is None:
        track_id = database.sqldb.get_track_id(track,create_new=False)

    if malojaconfig["USE_ALBUM_ARTWORK_FOR_TRACKS"]:
                      Severity: Minor
                      Found in maloja/images.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language