kristuff/patabase

View on GitHub

Showing 24 of 24 total issues

Method addForeignKey has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function addForeignKey(string $fkName, string $srcTable, string $srcColumn, string $refTable, string $refColumn): bool
Severity: Minor
Found in lib/Driver/Mysql/MysqlDriver.php - About 35 mins to fix

    Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct(array $settings)
        {
            // check for required attributes
            foreach ($this->dsnAttributes as $attribute) {
                if (! array_key_exists($attribute, $settings)) {
    Severity: Minor
    Found in lib/Driver/DatabaseDriver.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                    return json_encode($results, JSON_PRETTY_PRINT | JSON_NUMERIC_CHECK);   
    Severity: Major
    Found in lib/Query/QueryBuilder.php - About 30 mins to fix

      Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function execute(): bool
          {
              try {
                  // prepare bind execute
                  if (!isset($this->pdoStatement)){
      Severity: Minor
      Found in lib/Query/QueryBuilder.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language