Sign upLogin

kronusme/dota2-api

View on GitHub
Star

Showing 29 of 29 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Dota2Api\Mappers;

use Dota2Api\Utils\Request;
Severity: Major
Found in includes/Mappers/LeaguesMapperWeb.php and 1 other location - About 5 hrs to fix
includes/Mappers/ItemsMapperWeb.php on lines 1..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 185.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace Dota2Api\Mappers;

use Dota2Api\Models\Item;
Severity: Major
Found in includes/Mappers/ItemsMapperWeb.php and 1 other location - About 5 hrs to fix
includes/Mappers/LeaguesMapperWeb.php on lines 1..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 185.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function parseLoadedMatches has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    protected function parseLoadedMatches($leagueLiveMatches)
    {
        $leagueLiveMatches = $leagueLiveMatches->games;
        $liveMatches = array();
        if (null === $leagueLiveMatches->game) {
Severity: Minor
Found in includes/Mappers/LeagueMapper.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Db.php has 295 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Dota2Api\Utils;

use PDO;
Severity: Minor
Found in includes/Utils/Db.php - About 3 hrs to fix

    MatchesMapper has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    abstract class MatchesMapper
{
    /**
     * Search matches with a player name, exact match only
     * @var string
    Severity: Minor
    Found in includes/Mappers/MatchesMapper.php - About 2 hrs to fix

      Function parseScoreboard has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          private function parseScoreboard(&$liveMatch, $scoreboard, $teamSide)
    {
        $team = $scoreboard->{$teamSide};
        $liveMatch->set($teamSide.'_score', strval($team->score));
        $liveMatch->set('tower_status_' . $teamSide, strval($team->tower_state));
      Severity: Minor
      Found in includes/Mappers/LeagueMapper.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parseLoadedMatches has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function parseLoadedMatches($leagueLiveMatches)
    {
        $leagueLiveMatches = $leagueLiveMatches->games;
        $liveMatches = array();
        if (null === $leagueLiveMatches->game) {
      Severity: Major
      Found in includes/Mappers/LeagueMapper.php - About 2 hrs to fix

        Function parse has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function parse($parseTo = '')
    {
        $parseTo = str_replace('.', '', $parseTo); // allow to use '6.86' and '686'
        $p = __DIR__ . '/../../' . self::PATH . '/';
        $fullpath = $p . $this->_filename;
        Severity: Minor
        Found in includes/Data/Data.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            private static $radiantTowersPositions = array(
        array(130, 795), // t4 top
        array(150, 810), // t4 bot

        array(250, 870), // t3 bot
        Severity: Major
        Found in includes/Utils/Map.php and 1 other location - About 1 hr to fix
        includes/Utils/Map.php on lines 52..67

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 117.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            private static $direTowersPositions = array(
        array(830, 180), // t4 top
        array(860, 205), // t4 bot

        array(895, 310), // t3 bot
        Severity: Major
        Found in includes/Utils/Map.php and 1 other location - About 1 hr to fix
        includes/Utils/Map.php on lines 26..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 117.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function deletePDO has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function deletePDO($table, array $where = array(), $limit = 1)
    {
        $limit = (int)$limit;
        if (count($where) === 0) {
            return false;
        Severity: Minor
        Found in includes/Utils/Db.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getImage has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getImage()
    {
        $path = __DIR__ . '/../../' . $this->_folder;
        $this->_canvas = imagecreatefromjpeg($path . 'dota_map.jpg');
        if ($this->_canvas === false) {
        Severity: Minor
        Found in includes/Utils/Map.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method insertManyPDO has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function insertManyPDO($table, array $fields, array $data = array(), $update = false)
    {
        if (count($data) === 0) {
            return false;
        }
        Severity: Minor
        Found in includes/Utils/Db.php - About 1 hr to fix

          Method updatePDO has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function updatePDO($table, array $data, array $where = array())
    {

        if (count($data) === 0) {
            return false;
          Severity: Minor
          Found in includes/Utils/Db.php - About 1 hr to fix

            Method deletePDO has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function deletePDO($table, array $where = array(), $limit = 1)
    {
        $limit = (int)$limit;
        if (count($where) === 0) {
            return false;
            Severity: Minor
            Found in includes/Utils/Db.php - About 1 hr to fix

              Function updatePDO has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function updatePDO($table, array $data, array $where = array())
    {

        if (count($data) === 0) {
            return false;
              Severity: Minor
              Found in includes/Utils/Db.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method parseScoreboard has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function parseScoreboard(&$liveMatch, $scoreboard, $teamSide)
    {
        $team = $scoreboard->{$teamSide};
        $liveMatch->set($teamSide.'_score', strval($team->score));
        $liveMatch->set('tower_status_' . $teamSide, strval($team->tower_state));
              Severity: Minor
              Found in includes/Mappers/LeagueMapper.php - About 1 hr to fix

                Function insertManyPDO has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function insertManyPDO($table, array $fields, array $data = array(), $update = false)
    {
        if (count($data) === 0) {
            return false;
        }
                Severity: Minor
                Found in includes/Utils/Db.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method insertPDO has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function insertPDO($table, array $data = array())
    {
        if (count($data) === 0) {
            return false;
        }
                Severity: Minor
                Found in includes/Utils/Db.php - About 1 hr to fix

                  Method getImage has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getImage()
    {
        $path = __DIR__ . '/../../' . $this->_folder;
        $this->_canvas = imagecreatefromjpeg($path . 'dota_map.jpg');
        if ($this->_canvas === false) {
                  Severity: Minor
                  Found in includes/Utils/Map.php - About 1 hr to fix
                    Severity
                    Category
                    Status
                    Source
                    Language