kronusme/dota2-api

View on GitHub

Showing 29 of 29 total issues

Method load has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function load($liveMatchId)
    {
        $db = Db::obtain();
        $queryForMatch = 'SELECT * FROM ' . Db::realTablename($this->matchesTable) . ' WHERE match_id=?';
        $queryForSlots = 'SELECT * FROM ' . Db::realTablename($this->slotsTable) . ' WHERE match_id=?';
Severity: Minor
Found in includes/Mappers/LiveMatchMapperDb.php - About 1 hr to fix

    Method load has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function load()
        {
            $request = new Request(
                self::TEAMS_STEAM_URL,
                array(
    Severity: Minor
    Found in includes/Mappers/TeamsMapperWeb.php - About 1 hr to fix

      Function load has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function load()
          {
              $request = new Request(
                  self::TEAMS_STEAM_URL,
                  array(
      Severity: Minor
      Found in includes/Mappers/TeamsMapperWeb.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method obtain has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static function obtain($server = null, $user = null, $pass = null, $database = null, $pref = null)
      Severity: Minor
      Found in includes/Utils/Db.php - About 35 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function __construct($server = null, $user = null, $pass = null, $database = null, $pref = null)
        Severity: Minor
        Found in includes/Utils/Db.php - About 35 mins to fix

          Function getTeam has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function getTeam($t)
              {
                  $teamInfo = (array)$t;
                  $team = new Team();
                  $fields = array_keys($teamInfo);
          Severity: Minor
          Found in includes/Mappers/TeamsMapperWeb.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function insertPDO has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function insertPDO($table, array $data = array())
              {
                  if (count($data) === 0) {
                      return false;
                  }
          Severity: Minor
          Found in includes/Utils/Db.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _parseJsonFile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function _parseJsonFile($fullpath)
              {
                  $return = array();
                  if (file_exists($fullpath)) {
                      $content = file_get_contents($fullpath);
          Severity: Minor
          Found in includes/Data/Data.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function load has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function load($tid)
              {
                  $addSql = '';
                  if (!is_null($tid)) {
                      if (is_array($tid)) {
          Severity: Minor
          Found in includes/Mappers/TeamsMapperDb.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language