ksassnowski/laravel-beanstalkd-admin-ui

View on GitHub
src/Repositories/JobRepository.php

Summary

Maintainability
A
0 mins
Test Coverage

The method nextReady has a boolean flag argument $withStats, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function nextReady(string $tube, bool $withStats = false): ?Job
Severity: Minor
Found in src/Repositories/JobRepository.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method nextBuried has a boolean flag argument $withStats, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function nextBuried(string $tube, bool $withStats = false): ?Job
Severity: Minor
Found in src/Repositories/JobRepository.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method nextDelayed has a boolean flag argument $withStats, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function nextDelayed(string $tube, bool $withStats = false): ?Job
Severity: Minor
Found in src/Repositories/JobRepository.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method next has a boolean flag argument $withStats, which is a certain sign of a Single Responsibility Principle violation.
Open

    private function next(string $type, string $tube, bool $withStats = false): ?Job
Severity: Minor
Found in src/Repositories/JobRepository.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

There are no issues that match your filters.

Category
Status