kwn/number-to-words

View on GitHub

Showing 211 of 211 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php

namespace NumberToWords\Language\Uzbek;

use NumberToWords\Language\ExponentGetter;
Severity: Major
Found in src/Language/Uzbek/UzbekExponentGetter.php and 3 other locations - About 1 hr to fix
src/Language/Azerbaijani/AzerbaijaniExponentGetter.php on lines 1..38
src/Language/English/EnglishExponentGetter.php on lines 1..38
src/Language/Kurdish/KurdishExponentGetter.php on lines 1..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php

namespace NumberToWords\Language\English;

use NumberToWords\Language\ExponentGetter;
Severity: Major
Found in src/Language/English/EnglishExponentGetter.php and 3 other locations - About 1 hr to fix
src/Language/Azerbaijani/AzerbaijaniExponentGetter.php on lines 1..38
src/Language/Kurdish/KurdishExponentGetter.php on lines 1..38
src/Language/Uzbek/UzbekExponentGetter.php on lines 1..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php

namespace NumberToWords\Language\Kurdish;

use NumberToWords\Language\ExponentGetter;
Severity: Major
Found in src/Language/Kurdish/KurdishExponentGetter.php and 3 other locations - About 1 hr to fix
src/Language/Azerbaijani/AzerbaijaniExponentGetter.php on lines 1..38
src/Language/English/EnglishExponentGetter.php on lines 1..38
src/Language/Uzbek/UzbekExponentGetter.php on lines 1..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

<?php

namespace NumberToWords\Language\Azerbaijani;

use NumberToWords\Language\ExponentGetter;
Severity: Major
Found in src/Language/Azerbaijani/AzerbaijaniExponentGetter.php and 3 other locations - About 1 hr to fix
src/Language/English/EnglishExponentGetter.php on lines 1..38
src/Language/Kurdish/KurdishExponentGetter.php on lines 1..38
src/Language/Uzbek/UzbekExponentGetter.php on lines 1..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method getWordsBySplittingIntoTriplets has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getWordsBySplittingIntoTriplets(int $number): array
    {
        $words = [];
        $triplets = $this->numberToTripletsConverter->convertToTriplets($number);

Severity: Minor
Found in src/NumberTransformer/GenericNumberTransformer.php - About 1 hr to fix

    Method toWords has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function toWords($num)
        {
            $return = '';
    
            if ($num === 0) {
    Severity: Minor
    Found in src/Legacy/Numbers/Words/Locale/Fr/Be.php - About 1 hr to fix

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              switch (strlen($number)) {
                  case 3:
                      $h = (int) substr($number, -3, 1);
      
                  case 2:
      Severity: Major
      Found in src/Legacy/Numbers/Words/Locale/Cs.php and 5 other locations - About 1 hr to fix
      src/Legacy/Numbers/Words/Locale/Dk.php on lines 110..124
      src/Legacy/Numbers/Words/Locale/Et.php on lines 195..209
      src/Legacy/Numbers/Words/Locale/Lt.php on lines 93..107
      src/Legacy/Numbers/Words/Locale/Nl.php on lines 160..174
      src/Legacy/Numbers/Words/Locale/Sv.php on lines 115..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              switch (strlen($num)) {
                  case 3:
                      $h = (int) substr($num, -3, 1);
      
                  case 2:
      Severity: Major
      Found in src/Legacy/Numbers/Words/Locale/Nl.php and 5 other locations - About 1 hr to fix
      src/Legacy/Numbers/Words/Locale/Cs.php on lines 107..121
      src/Legacy/Numbers/Words/Locale/Dk.php on lines 110..124
      src/Legacy/Numbers/Words/Locale/Et.php on lines 195..209
      src/Legacy/Numbers/Words/Locale/Lt.php on lines 93..107
      src/Legacy/Numbers/Words/Locale/Sv.php on lines 115..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              switch (strlen($num)) {
                  case 3:
                      $h = (int) substr($num, -3, 1);
      
                  case 2:
      Severity: Major
      Found in src/Legacy/Numbers/Words/Locale/Sv.php and 5 other locations - About 1 hr to fix
      src/Legacy/Numbers/Words/Locale/Cs.php on lines 107..121
      src/Legacy/Numbers/Words/Locale/Dk.php on lines 110..124
      src/Legacy/Numbers/Words/Locale/Et.php on lines 195..209
      src/Legacy/Numbers/Words/Locale/Lt.php on lines 93..107
      src/Legacy/Numbers/Words/Locale/Nl.php on lines 160..174

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              switch (strlen($number)) {
                  case 3:
                      $h = (int) substr($number, -3, 1);
      
                  case 2:
      Severity: Major
      Found in src/Legacy/Numbers/Words/Locale/Dk.php and 5 other locations - About 1 hr to fix
      src/Legacy/Numbers/Words/Locale/Cs.php on lines 107..121
      src/Legacy/Numbers/Words/Locale/Et.php on lines 195..209
      src/Legacy/Numbers/Words/Locale/Lt.php on lines 93..107
      src/Legacy/Numbers/Words/Locale/Nl.php on lines 160..174
      src/Legacy/Numbers/Words/Locale/Sv.php on lines 115..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              switch (strlen($num)) {
                  case 3:
                      $h = (int) substr($num, -3, 1);
      
                  case 2:
      Severity: Major
      Found in src/Legacy/Numbers/Words/Locale/Et.php and 5 other locations - About 1 hr to fix
      src/Legacy/Numbers/Words/Locale/Cs.php on lines 107..121
      src/Legacy/Numbers/Words/Locale/Dk.php on lines 110..124
      src/Legacy/Numbers/Words/Locale/Lt.php on lines 93..107
      src/Legacy/Numbers/Words/Locale/Nl.php on lines 160..174
      src/Legacy/Numbers/Words/Locale/Sv.php on lines 115..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              switch (strlen($number)) {
                  case 3:
                      $h = (int) substr($number, -3, 1);
      
                  case 2:
      Severity: Major
      Found in src/Legacy/Numbers/Words/Locale/Lt.php and 5 other locations - About 1 hr to fix
      src/Legacy/Numbers/Words/Locale/Cs.php on lines 107..121
      src/Legacy/Numbers/Words/Locale/Dk.php on lines 110..124
      src/Legacy/Numbers/Words/Locale/Et.php on lines 195..209
      src/Legacy/Numbers/Words/Locale/Nl.php on lines 160..174
      src/Legacy/Numbers/Words/Locale/Sv.php on lines 115..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method toWords has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
          {
              $dictionary = new LatvianDictionary();
              $numberTransformer = new LatvianNumberTransformer();
      
      
      Severity: Minor
      Found in src/CurrencyTransformer/LatvianCurrencyTransformer.php - About 1 hr to fix

        Method toWords has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function toWords($number)
            {
                $ret = '';
        
                if ($number === 0) {
        Severity: Minor
        Found in src/Legacy/Numbers/Words/Locale/Fr.php - About 1 hr to fix

          Method toWords has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
              {
                  $dictionary = new LithuanianDictionary();
                  $numberTransformer = new LithuanianNumberTransformer();
          
          
          Severity: Minor
          Found in src/CurrencyTransformer/LithuanianCurrencyTransformer.php - About 1 hr to fix

            Method transformToWords has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function transformToWords(int $number, int $power): string
                {
                    $units = $number % 10;
                    $tens = (int) ($number / 10) % 10;
                    $hundreds = (int) ($number / 100) % 10;
            Severity: Minor
            Found in src/Language/German/GermanTripletTransformer.php - About 1 hr to fix

              Consider simplifying this complex logical expression.
              Open

                                  if ($pow == 1) {
                                      $ret[$j] .= $this->showDigitsGroup(
                                              $numGroups[$i],
                                              0,
                                              !$this->lastAnd && $i
              Severity: Major
              Found in src/Legacy/Numbers/Words/Locale/Mk.php - About 1 hr to fix

                Function transformToWords has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function transformToWords(int $number, int $power): string
                    {
                        $units = $number % 10;
                        $tens = (int) ($number / 10) % 10;
                        $hundreds = (int) ($number / 100) % 10;
                Severity: Minor
                Found in src/Language/Serbian/SerbianTripletTransformer.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    private static $exponent = [
                        ['', '', ''],
                        ['الف', 'الفين', 'آلاف'],
                        ['مليون', 'مليونين', 'ملايين'],
                        ['مليار', 'مليارين', 'مليارات'],
                Severity: Minor
                Found in src/Language/Arabic/ArabicExponentInflector.php and 1 other location - About 55 mins to fix
                src/Language/Latvian/LatvianExponentInflector.php on lines 9..17

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    private static array $exponent = [
                        ['', '', ''],
                        ['tūkstotis', 'tūkstoši', 'tūkstoši'],
                        ['miljons', 'miljoni', 'miljons'],
                        ['miljards', 'miljardi', 'miljardi'],
                Severity: Minor
                Found in src/Language/Latvian/LatvianExponentInflector.php and 1 other location - About 55 mins to fix
                src/Language/Arabic/ArabicExponentInflector.php on lines 9..17

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language