Sign upLogin

kwn/number-to-words

View on GitHub
Star

Showing 207 of 207 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

<?php

namespace NumberToWords\NumberTransformer;

use NumberToWords\Language\Uzbek\UzbekDictionary;
Severity: Major
Found in src/NumberTransformer/UzbekNumberTransformer.php and 4 other locations - About 1 hr to fix
src/NumberTransformer/AzerbaijaniNumberTransformer.php on lines 1..28
src/NumberTransformer/EnglishNumberTransformer.php on lines 1..28
src/NumberTransformer/GermanNumberTransformer.php on lines 1..28
src/NumberTransformer/LatvianNumberTransformer.php on lines 1..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

<?php

namespace NumberToWords\NumberTransformer;

use NumberToWords\Language\German\GermanDictionary;
Severity: Major
Found in src/NumberTransformer/GermanNumberTransformer.php and 4 other locations - About 1 hr to fix
src/NumberTransformer/AzerbaijaniNumberTransformer.php on lines 1..28
src/NumberTransformer/EnglishNumberTransformer.php on lines 1..28
src/NumberTransformer/LatvianNumberTransformer.php on lines 1..28
src/NumberTransformer/UzbekNumberTransformer.php on lines 1..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

<?php

namespace NumberToWords\NumberTransformer;

use NumberToWords\Language\Azerbaijani\AzerbaijaniDictionary;
Severity: Major
Found in src/NumberTransformer/AzerbaijaniNumberTransformer.php and 4 other locations - About 1 hr to fix
src/NumberTransformer/EnglishNumberTransformer.php on lines 1..28
src/NumberTransformer/GermanNumberTransformer.php on lines 1..28
src/NumberTransformer/LatvianNumberTransformer.php on lines 1..28
src/NumberTransformer/UzbekNumberTransformer.php on lines 1..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

<?php

namespace NumberToWords\NumberTransformer;

use NumberToWords\Language\English\EnglishDictionary;
Severity: Major
Found in src/NumberTransformer/EnglishNumberTransformer.php and 4 other locations - About 1 hr to fix
src/NumberTransformer/AzerbaijaniNumberTransformer.php on lines 1..28
src/NumberTransformer/GermanNumberTransformer.php on lines 1..28
src/NumberTransformer/LatvianNumberTransformer.php on lines 1..28
src/NumberTransformer/UzbekNumberTransformer.php on lines 1..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function toCurrencyWords has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function toCurrencyWords($currency, $decimal, $fraction = null)
    {
        $currency = strtoupper($currency);

        if (!array_key_exists($currency, self::$currencyNames)) {
Severity: Minor
Found in src/Legacy/Numbers/Words/Locale/Hu.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function toCurrencyWords has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function toCurrencyWords($currency, $decimal, $fraction = null)
    {
        $currency = strtoupper($currency);

        if (!array_key_exists($currency, static::$currencyNames)) {
Severity: Minor
Found in src/Legacy/Numbers/Words/Locale/Es.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function toCurrencyWords has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function toCurrencyWords($currency, $decimal, $fraction = null)
    {
        $currency = strtoupper($currency);

        if (!array_key_exists($currency, static::$currencyNames)) {
Severity: Minor
Found in src/Legacy/Numbers/Words/Locale/Ru.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function toWords has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    protected function toWords($number)
    {
        if ($number === 0) {
            return $this->zero;
        }
Severity: Minor
Found in src/Legacy/Numbers/Words/Locale/Tk.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function toCurrencyWords has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function toCurrencyWords($currency, $decimal, $fraction = null)
    {
        $currency = strtoupper($currency);

        if (!array_key_exists($currency, static::$currencyNames)) {
Severity: Minor
Found in src/Legacy/Numbers/Words/Locale/Fr.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method toWords has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
    {
        $dictionary = new SlovakDictionary();
        $numberToTripletsConverter = new NumberToTripletsConverter();
        $tripletTransformer = new SlovakTripletTransformer($dictionary);
Severity: Minor
Found in src/CurrencyTransformer/SlovakCurrencyTransformer.php - About 1 hr to fix

    Method toWords has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
    {
        $dictionary = new PolishDictionary();
        $numberToTripletsConverter = new NumberToTripletsConverter();
        $tripletTransformer = new PolishTripletTransformer($dictionary);
    Severity: Minor
    Found in src/CurrencyTransformer/PolishCurrencyTransformer.php - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      <?php

namespace NumberToWords\Language\Azerbaijani;

class AzerbaijaniNounGenderInflector
      Severity: Major
      Found in src/Language/Azerbaijani/AzerbaijaniNounGenderInflector.php and 2 other locations - About 1 hr to fix
      src/Language/Polish/PolishNounGenderInflector.php on lines 1..26
      src/Language/Slovak/SlovakNounGenderInflector.php on lines 1..26

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 113.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      <?php

namespace NumberToWords\Language\Polish;

class PolishNounGenderInflector
      Severity: Major
      Found in src/Language/Polish/PolishNounGenderInflector.php and 2 other locations - About 1 hr to fix
      src/Language/Azerbaijani/AzerbaijaniNounGenderInflector.php on lines 1..26
      src/Language/Slovak/SlovakNounGenderInflector.php on lines 1..26

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 113.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      <?php

namespace NumberToWords\Language\Slovak;

class SlovakNounGenderInflector
      Severity: Major
      Found in src/Language/Slovak/SlovakNounGenderInflector.php and 2 other locations - About 1 hr to fix
      src/Language/Azerbaijani/AzerbaijaniNounGenderInflector.php on lines 1..26
      src/Language/Polish/PolishNounGenderInflector.php on lines 1..26

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 113.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method toWords has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function toWords($num = 0, $noun = [])
    {
        if (empty($noun)) {
            $noun = [null, null, Gender::GENDER_ABSTRACT];
        }
      Severity: Minor
      Found in src/Legacy/Numbers/Words/Locale/Ro.php - About 1 hr to fix

        Function toWords has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function toWords($number)
    {
        $ret = '';

        if ($number === 0) {
        Severity: Minor
        Found in src/Legacy/Numbers/Words/Locale/Fr.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function toWords has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function toWords($num)
    {
        $return = '';

        if ($num === 0) {
        Severity: Minor
        Found in src/Legacy/Numbers/Words/Locale/Fr/Be.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function toWords has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function toWords($num)
    {
        $neg = 0;
        $ret = [];
        Severity: Minor
        Found in src/Legacy/Numbers/Words/Locale/Pt/Br.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method toCurrencyWords has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function toCurrencyWords($currency, $decimal, $fraction = null)
    {
        $return = '';
        $currency = strtoupper($currency);
        Severity: Minor
        Found in src/Legacy/Numbers/Words/Locale/Dk.php - About 1 hr to fix

          Method toCurrencyWords has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function toCurrencyWords($currency, $decimal, $fraction = null)
    {
        $currency = strtoupper($currency);

        if (!array_key_exists($currency, static::$currencyNames)) {
          Severity: Minor
          Found in src/Legacy/Numbers/Words/Locale/Fr.php - About 1 hr to fix
            Severity
            Category
            Status
            Source
            Language