kylekatarnls/nodejs-php-fallback

View on GitHub
src/NodejsPhpFallback/ComposerPlugin.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid unused parameters such as '$composer'.
Open

    public function activate(Composer $composer, IOInterface $io)

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$composer'.
Open

    public function deactivate(Composer $composer, IOInterface $io)

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$composer'.
Open

    public function uninstall(Composer $composer, IOInterface $io)

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Class implements undeclared interface \Composer\EventDispatcher\EventSubscriberInterface
Open

class ComposerPlugin implements PluginInterface, EventSubscriberInterface
Severity: Critical
Found in src/NodejsPhpFallback/ComposerPlugin.php by phan

Parameter $event has undeclared type \Composer\EventDispatcher\Event
Open

    public function onAutoloadDump(Event $event)

Parameter $io has undeclared type \Composer\IO\IOInterface
Open

    public function uninstall(Composer $composer, IOInterface $io)

Parameter $composer has undeclared type \Composer\Composer
Open

    public function uninstall(Composer $composer, IOInterface $io)

Class implements undeclared interface \Composer\Plugin\PluginInterface
Open

class ComposerPlugin implements PluginInterface, EventSubscriberInterface
Severity: Critical
Found in src/NodejsPhpFallback/ComposerPlugin.php by phan

Parameter $composer has undeclared type \Composer\Composer
Open

    public function activate(Composer $composer, IOInterface $io)

Parameter $composer has undeclared type \Composer\Composer
Open

    public function deactivate(Composer $composer, IOInterface $io)

Parameter $io has undeclared type \Composer\IO\IOInterface
Open

    public function deactivate(Composer $composer, IOInterface $io)

Parameter $io has undeclared type \Composer\IO\IOInterface
Open

    public function activate(Composer $composer, IOInterface $io)

Avoid using static access to class 'NodejsPhpFallback\NodejsPhpFallback' in method 'onAutoloadDump'.
Open

        NodejsPhpFallback::install($event);

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid variables with short names like $io. Configured minimum length is 3.
Open

    public function activate(Composer $composer, IOInterface $io)

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $io. Configured minimum length is 3.
Open

    public function deactivate(Composer $composer, IOInterface $io)

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $io. Configured minimum length is 3.
Open

    protected $io;

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $io. Configured minimum length is 3.
Open

    public function uninstall(Composer $composer, IOInterface $io)

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status