Sign upLogin

lbryio/chainquery

View on GitHub
Star
daemon/jobs/chainsync.go

Summary

Maintainability
C
1 day
Test Coverage

Method chainSyncStatus.alignVout has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
Open

func (c *chainSyncStatus) alignVout(v lbrycrd.Vout) error {
    colsToUpdate := make([]string, 0)
    if c.Vout.Value.Float64 != v.Value {
        c.Vout.Value.SetValid(v.Value)
        colsToUpdate = append(colsToUpdate, model.OutputColumns.Value)
Severity: Minor
Found in daemon/jobs/chainsync.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method chainSyncStatus.alignBlock has 59 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *chainSyncStatus) alignBlock(l *lbrycrd.GetBlockResponse) error {
    colsToUpdate := make([]string, 0)
    if c.Block.Hash != l.Hash {
        c.Block.Hash = l.Hash
        colsToUpdate = append(colsToUpdate, model.BlockColumns.Hash)
Severity: Minor
Found in daemon/jobs/chainsync.go - About 1 hr to fix

Method chainSyncStatus.alignVout has 7 return statements (exceeds 4 allowed).
Open

func (c *chainSyncStatus) alignVout(v lbrycrd.Vout) error {
    colsToUpdate := make([]string, 0)
    if c.Vout.Value.Float64 != v.Value {
        c.Vout.Value.SetValid(v.Value)
        colsToUpdate = append(colsToUpdate, model.OutputColumns.Value)
Severity: Major
Found in daemon/jobs/chainsync.go - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                if err != nil {
                    return err
                }
Severity: Major
Found in daemon/jobs/chainsync.go - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                if len(value) > 0 {
                    s, err := stake.DecodeSupportBytes(value, global.BlockChainName)
                    if err != nil {
                        return err
                    }
Severity: Major
Found in daemon/jobs/chainsync.go - About 45 mins to fix

Method chainSyncStatus.processNextBlock has 7 return statements (exceeds 4 allowed).
Open

func (c *chainSyncStatus) processNextBlock() error {
    c.LastHeight = c.LastHeight + 1
    blockHash, err := lbrycrd.LBRYcrdClient.GetBlockHash(c.LastHeight)
    if err != nil {
        return c.recordAndReturnError(c.LastHeight, "lbrycrd-getblockhash", err)
Severity: Major
Found in daemon/jobs/chainsync.go - About 45 mins to fix

Method chainSyncStatus.alignClaim has 6 return statements (exceeds 4 allowed).
Open

func (c *chainSyncStatus) alignClaim() error {
    storedClaim := datastore.GetClaim(c.Vout.ClaimID.String)
    if storedClaim == nil {
        return errors.Err("could not find claim with id %s", c.Vout.ClaimID.String)
    }
Severity: Major
Found in daemon/jobs/chainsync.go - About 40 mins to fix

Function getChainSyncJobStatus has 5 return statements (exceeds 4 allowed).
Open

func getChainSyncJobStatus() (*model.JobStatus, error) {
    jobStatus, err := model.FindJobStatusG(chainSyncJob)
    if errors.Is(sql.ErrNoRows, err) {
        syncState := chainSyncStatus{LastHeight: 0}
        bytes, err := json.Marshal(syncState)
Severity: Major
Found in daemon/jobs/chainsync.go - About 35 mins to fix

Method chainSyncStatus.alignTxs has 5 return statements (exceeds 4 allowed).
Open

func (c *chainSyncStatus) alignTxs(block *model.Block, txHashes []string) error {
    for _, txHash := range txHashes {
        lbrycrdTx, err := lbrycrd.GetRawTransactionResponse(txHash)
        if err != nil {
            return c.recordAndReturnError(c.LastHeight, "tx-hash-creation", err)
Severity: Major
Found in daemon/jobs/chainsync.go - About 35 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if c.Vin.ScriptSigHex.String != v.ScriptSig.Hex {
            c.Vin.ScriptSigHex.String = v.ScriptSig.Hex
            c.Vin.ScriptSigHex.Valid = v.ScriptSig.Hex != ""
            colsToUpdate = append(colsToUpdate, model.InputColumns.ScriptSigHex)
        }
Severity: Minor
Found in daemon/jobs/chainsync.go and 1 other location - About 30 mins to fix
daemon/jobs/chainsync.go on lines 322..326

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if c.Vin.ScriptSigAsm.String != v.ScriptSig.Asm {
            c.Vin.ScriptSigAsm.String = v.ScriptSig.Asm
            c.Vin.ScriptSigAsm.Valid = v.ScriptSig.Asm != ""
            colsToUpdate = append(colsToUpdate, model.InputColumns.ScriptSigAsm)
        }
Severity: Minor
Found in daemon/jobs/chainsync.go and 1 other location - About 30 mins to fix
daemon/jobs/chainsync.go on lines 317..321

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

package jobs
Severity: Minor
Found in daemon/jobs/chainsync.go by gofmt

There are no issues that match your filters.

Category
Status