Sign upLogin

lbryio/chainquery

View on GitHub
Star
daemon/processing/block.go

Summary

Maintainability
A
2 hrs
Test Coverage

Function RunBlockProcessing has 7 return statements (exceeds 4 allowed).
Open

func RunBlockProcessing(stopper *stop.Group, height uint64) uint64 {
    defer metrics.Processing(time.Now(), "block")
    defer util.TimeTrack(time.Now(), "runBlockProcessing", "daemonprofile")
    if height == 0 {
        err := processGenesisBlock()
Severity: Major
Found in daemon/processing/block.go - About 45 mins to fix

Function checkHandleReorg has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
Open

func checkHandleReorg(height uint64, chainPrevHash string) (uint64, error) {
    prevHeight := height - 1
    depth := 0
    if height > 0 {
        prevBlock, err := model.Blocks(qm.Where(model.BlockColumns.Height+"=?", prevHeight), qm.Load("BlockHashTransactions")).OneG()
Severity: Minor
Found in daemon/processing/block.go - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkHandleReorg has 6 return statements (exceeds 4 allowed).
Open

func checkHandleReorg(height uint64, chainPrevHash string) (uint64, error) {
    prevHeight := height - 1
    depth := 0
    if height > 0 {
        prevBlock, err := model.Blocks(qm.Where(model.BlockColumns.Height+"=?", prevHeight), qm.Load("BlockHashTransactions")).OneG()
Severity: Major
Found in daemon/processing/block.go - About 40 mins to fix

There are no issues that match your filters.

Category
Status