leap-protocol/leap-js

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    else if (type == "i16") {
      integer_validity_check(item);
      value = clamp(item, -0x8000, 0x7FFF);
      value = (value < 0) ? (value + 0x10000) : (value);
      return to_padded_hex_string(value, 4);

Found in src/typeCodec.js and 2 other locations - About 1 hr to fix

Read up
Read up

src/typeCodec.js on lines 33..91

src/typeCodec.js on lines 45..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    else if (type == "i32") {
      integer_validity_check(item);
      value = clamp(item, -0x80000000, 0x7FFFFFFF);
      value = (value < 0) ? (value + 0x100000000) : (value);
      return to_padded_hex_string(value, 8);

Found in src/typeCodec.js and 2 other locations - About 1 hr to fix

Read up
Read up

src/typeCodec.js on lines 33..91

src/typeCodec.js on lines 39..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Function `verify_item` has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  verify_item(item, branch) {
    if (typeof item !== "object") {
      this.failure = `data item "${item}" in ${branch} must be an object`;
    }
    else {

Found in src/configDataVerifier.js - About 55 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `encode` has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  encode(packets){
    if (this._is_valid == false) {
      return utf8.encode("");
    }
    if ((packets instanceof packet.Packet) == true) {

Found in src/codec.js - About 55 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `verify_symbols` has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  verify_symbols(config) {
    const symbols = ["separator", "compound", "end"];

    for (let i in symbols) {
      const symbol = symbols[i];

Found in src/configVerifier.js - About 55 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

          for (i in next_branches) {
            const branch = next_branches[i];
            branches.push(name + "/" + branch);
          }

Found in src/explore.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

      if (type.includes(item)) {
        value = type.indexOf(item);
        if (value != undefined) {
          return to_padded_hex_string(value, 2);
        }

Found in src/typeCodec.js - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

          for (i in next_decendants) {
            decendants.push(name + "/" + next_decendants[i]);
          }

Found in src/explore.js - About 45 mins to fix

Function `_decode_packet` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  _decode_packet(string) {
    string = utf8.decode(string);
    const start = string[0];
    const category = this._category_from_start(start);
    if (category == null) {

Found in src/codec.js - About 45 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

      if (value < type.length) {
        return type[value];
      }

Found in src/typeCodec.js - About 45 mins to fix

Function `extract_types` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

exports.extract_types = function extract_types(root, path) {
  const start = exports.get_struct(root, path);
  const types = [];
  if (start != null) {
    if (protocolKey.TYPE in start) {

Found in src/explore.js - About 45 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `verify_typeset` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  verify_typeset(typeset, branch) {
    if (typeof typeset === "object") {
      for (let i in typeset) {
        const item = typeset[i];
        if ((typeof item !== "string")

Found in src/configDataVerifier.js - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `verify_dataset` has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  verify_dataset(data, branch) {
    if (data.length == 0) {
      this.failure = `data in ${branch} is empty`;
    }
    else {

Found in src/configDataVerifier.js - About 35 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many `return` statements within this function.
Open

      return (item == true) ? ("1") : ("0");

Found in src/typeCodec.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

    return null;

Found in src/typeCodec.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

        return type[value];

Found in src/typeCodec.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

        return "";

Found in src/typeCodec.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

    return true;

Found in src/configVerifier.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return to_padded_hex_string(value, 8);

Found in src/typeCodec.js - About 30 mins to fix

Avoid too many `return` statements within this function.
Open

      return value;

Found in src/typeCodec.js - About 30 mins to fix