Showing 74 of 74 total issues
Function _buildPlugin
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
_buildPlugin({ addonContext }) {
const plugin = require('./lib/ast-transform')({ addonContext });
return {
name: 'ember-ast-hot-load-babel-plugin',
plugin,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function extractFileDataToResult
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
function extractFileDataToResult(data, queryFile, queryComponents) {
const definer = 'define(';
const exports = data.split(definer);
const originalFile = exports.join(definer);
const components = queryComponents.split(',').filter((name) => name);
Function clear
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
function clear(context, owner, name, originalName) {
if (context.get('templateCompilerKey')) {
// Ember v3.2
var templateCompiler = owner.lookup(context.get('templateCompilerKey'));
var compileTimeLookup = templateCompiler.resolver;
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (context.get('templateCompilerKey')) {
// Ember v3.2
var templateCompiler = owner.lookup(context.get('templateCompilerKey'));
var compileTimeLookup = templateCompiler.resolver;
var compileRuntimeResolver = compileTimeLookup.resolver;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 65.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
} else if (context.get('templateOptionsKey')) {
// Ember v3.1.1
var templateOptions = owner.lookup(context.get('templateOptionsKey'));
var optionsTimeLookup = templateOptions.resolver;
var optionsRuntimeResolver = optionsTimeLookup.resolver;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 65.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function initialize
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function initialize(application) {
if (typeof window !== 'object') {
return;
}
Function isAngleBrackedComponent
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
function isAngleBrackedComponent(node) {
const tagName = node.tag;
if (tagName.startsWith(':')) {
return false;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function convertComponent
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
function convertComponent(
input,
b,
{ helpers } = {
helpers: [],
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _getTemplateCompilerPath
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
_getTemplateCompilerPath() {
if (this._OPTIONS && this._OPTIONS['templateCompilerPath']) {
return this._OPTIONS['templateCompilerPath'];
}
const npmCompilerPath = path.join(
Function getRouteScopedComponents
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function getRouteScopedComponents() {
if (typeof window === 'undefined') {
return [];
}
const pairs = Object.keys(window.requirejs ? window.requirejs.entries : {})
Function _assignOptions
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
_assignOptions(app) {
let appOptions = app.options || {};
let addonOptions = appOptions[ADDON_NAME] || {};
const env = app.env;
this._ENV = env;
Function getMUScopedComponents
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function getMUScopedComponents() {
const muComponentsPath = '/ui/components/';
if (typeof window === 'undefined') {
return [];
}
Function _buildPlugin
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
_buildPlugin({ addonContext }) {
const plugin = require('./lib/ast-transform')({ addonContext });
return {
name: 'ember-ast-hot-load-babel-plugin',
plugin,
Function _isComponent
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
_isComponent(rawName) {
if (typeof rawName === 'object' && rawName !== null) {
return true;
}
const name = rawName || '';
Function registerDynamicComponent
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
registerDynamicComponent(name) {
if (this.hasDynamicHelperWrapperComponent(name)) {
return;
}
this.printError(name);
Function fileDidChange
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
async function fileDidChange(results) {
var filePath = results.filePath || '';
ui.writeLine(filePath);
Function looksLikeRouteTemplate
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function looksLikeRouteTemplate(path, podModulePrefix = 'pods') {
// mu app case
if (path.includes('/src/ui/')) {
return (
path.includes('/routes/') &&
Function _isComponent
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
_isComponent(rawName) {
if (typeof rawName === 'object' && rawName !== null) {
return true;
}
const name = rawName || '';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _scopedComponentNames
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
_scopedComponentNames(name, scope) {
const closestRelativeName = []
.concat(this.muScopedComponents, this.currentRouteComponents())
.filter((resolvedName) => resolvedName.endsWith(name))
.pop();
Function findEntypointFile
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
function findEntypointFile(
fileName,
lookupFolder = ['dist', 'assets', ''].join(path.sep)
) {
if (lookupFolder.charAt(lookupFolder.length - 1) !== path.sep) {