Sign upLogin

lifeart/ember-ast-hot-load

View on GitHub
Star

Showing 74 of 74 total issues

Avoid too many return statements within this function.
Open

    return renderComponentName;
Severity: Major
Found in addon/helpers/hot-load.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return true;
    Severity: Major
    Found in lib/ast-transform.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return node;
      Severity: Major
      Found in lib/ast-transform.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return this.reloadWindow();
        Severity: Major
        Found in addon/services/hot-loader.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return false;
          Severity: Major
          Found in addon/services/hot-loader.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              return false;
            Severity: Major
            Found in lib/ast-transform.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return false;
              Severity: Major
              Found in lib/ast-transform.js - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (compilerMatch && compilerMatch.length > 0) {
      if (service.__isAlive()) {
        service.set('templateCompilerKey', name);
      }
    }
                Severity: Minor
                Found in addon/instance-initializers/resolver-hot-loader-patch.js and 1 other location - About 30 mins to fix
                addon/instance-initializers/resolver-hot-loader-patch.js on lines 22..26

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid too many return statements within this function.
                Open

                        return hotLoader.renderDynamicComponentHelper(
          name,
          context,
          maybePropertyValue
        );
                Severity: Major
                Found in addon/helpers/hot-load.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return false;
                  Severity: Major
                  Found in lib/ast-transform.js - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if (optionsMatch && optionsMatch.length > 0) {
      if (service.__isAlive()) {
        service.set('templateOptionsKey', name);
      }
    }
                    Severity: Minor
                    Found in addon/instance-initializers/resolver-hot-loader-patch.js and 1 other location - About 30 mins to fix
                    addon/instance-initializers/resolver-hot-loader-patch.js on lines 28..32

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function _scopedComponentNames has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      _scopedComponentNames(name, scope) {
    const closestRelativeName = []
      .concat(this.muScopedComponents, this.currentRouteComponents())
      .filter((resolvedName) => resolvedName.endsWith(name))
      .pop();
                    Severity: Minor
                    Found in addon/services/hot-loader.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function clearRequirejsCache has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export function clearRequirejsCache(context, componentName) {
  const owner = getOwner(context);
  const config = owner.resolveRegistration('config:environment');

  const modulePrefix = get(config, 'modulePrefix') || 'dummy';
                    Severity: Minor
                    Found in addon/utils/cleaners.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function _ensureFindHost has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                      _ensureFindHost() {
    if (!this._findHost) {
      this._findHost = function findHostShim() {
        let current = this;
        let app;
                    Severity: Minor
                    Found in index.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language