Sign upLogin

linuxmuster/linuxmuster-linuxclient7

View on GitHub
Star
usr/lib/python3/dist-packages/linuxmusterLinuxclient7/hooks.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function _getRemoteHookScripts has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def _getRemoteHookScripts(hookType):
    if not hookType in remoteScriptNames:
        return False, None

    rc, networkConfig = config.network()
Severity: Minor
Found in usr/lib/python3/dist-packages/linuxmusterLinuxclient7/hooks.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _dictsToEnv has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def _dictsToEnv(dictsAndPrefixes):
    environmentDict = {}
    for prefix in dictsAndPrefixes:
        for key in dictsAndPrefixes[prefix]:
            if type(dictsAndPrefixes[prefix][key]) is list:
Severity: Minor
Found in usr/lib/python3/dist-packages/linuxmusterLinuxclient7/hooks.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return True, [hookScriptPathTemplate.format("lmn"), hookScriptPathTemplate.format("custom")]
Severity: Major
Found in usr/lib/python3/dist-packages/linuxmusterLinuxclient7/hooks.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return False, None
    Severity: Major
    Found in usr/lib/python3/dist-packages/linuxmusterLinuxclient7/hooks.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return False, None
      Severity: Major
      Found in usr/lib/python3/dist-packages/linuxmusterLinuxclient7/hooks.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status