Sign upLogin

liquidm/zmachine

View on GitHub
Star
lib/zmachine/connection.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Class Connection has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Connection

    extend Forwardable

    attr_accessor :channel
Severity: Minor
Found in lib/zmachine/connection.rb - About 4 hrs to fix

    Method process_events has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        def process_events
      return unless valid?
      ZMachine.logger.debug("zmachine:connection:#{__method__}", connection: self) if ZMachine.debug
      if @channel_key.connectable?
        connectable!
    Severity: Minor
    Found in lib/zmachine/connection.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method readable! has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def readable!
      ZMachine.logger.debug("zmachine:connection:#{__method__}", connection: self) if ZMachine.debug
      loop do
        mark_active!
        data = @channel.read_inbound_data
    Severity: Minor
    Found in lib/zmachine/connection.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status