Sign upLogin

liquidm/zmachine

View on GitHub
Star
lib/zmachine/connection_manager.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method unbind_connection has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def unbind_connection(connection)
      after_writing = false
      reason = nil
      connection, after_writing, reason = *connection if connection.is_a?(Array)
      if connection.method(:unbind).arity != 0
Severity: Minor
Found in lib/zmachine/connection_manager.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method bind has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def bind(address, port_or_type, handler, *args, &block)
Severity: Minor
Found in lib/zmachine/connection_manager.rb - About 35 mins to fix

    Method connect has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def connect(address, port_or_type, handler, *args, &block)
    Severity: Minor
    Found in lib/zmachine/connection_manager.rb - About 35 mins to fix

      Method add_new_connections has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def add_new_connections
      @new_connections.each do |connection|
        ZMachine.logger.debug("zmachine:connection_manager:#{__method__}", connection: connection) if ZMachine.debug
        begin
          connection.register(@selector)
      Severity: Minor
      Found in lib/zmachine/connection_manager.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status