Sign upLogin

lncm/noma

View on GitHub
Star
noma/lnd.py

Summary

Maintainability
A
3 hrs
Test Coverage

subprocess call - check for execution of untrusted input.
Open

        complete = run(["scp",
                        "-B",
                        "-i {}".format(cfg.SSH_IDENTITY),
                        "-p",
                        "-P {}".format(cfg.SSH_PORT),
Severity: Info
Found in noma/lnd.py by bandit

Consider possible security implications associated with call module.
Open

from subprocess import call, run
Severity: Info
Found in noma/lnd.py by bandit

Starting a process with a partial executable path
Open

        complete = run(["scp",
                        "-B",
                        "-i {}".format(cfg.SSH_IDENTITY),
                        "-p",
                        "-P {}".format(cfg.SSH_PORT),
Severity: Info
Found in noma/lnd.py by bandit

Standard pseudo-random generators are not suitable for security/cryptographic purposes.
Open

    return "".join(choice(letters) for i in range(string_length))
Severity: Info
Found in noma/lnd.py by bandit

Starting a process with a partial executable path
Open

            call(
                [
                    "docker",
                    "exec",
                    cfg.LND_MODE + "_lnd_1",
Severity: Info
Found in noma/lnd.py by bandit

Try, Except, Pass detected.
Open

    except Exception:
Severity: Info
Found in noma/lnd.py by bandit

subprocess call - check for execution of untrusted input.
Open

            call(
                [
                    "docker",
                    "exec",
                    cfg.LND_MODE + "_lnd_1",
Severity: Info
Found in noma/lnd.py by bandit

Try, Except, Pass detected.
Open

        except Exception:
Severity: Info
Found in noma/lnd.py by bandit

File lnd.py has 282 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
LND related functionality
"""
import pathlib
from subprocess import call, run
Severity: Minor
Found in noma/lnd.py - About 2 hrs to fix

    Function check has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def check():
    """Check lnd filesystem structure"""
    if cfg.LND_PATH.is_dir():
        print("✅ lnd directory exists")
    else:
    Severity: Minor
    Found in noma/lnd.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Line too long (81 > 79 characters)
    Open

        """Either load the wallet password from PASSWORD_FILE_PATH, or generate a new
    Severity: Minor
    Found in noma/lnd.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    There are no issues that match your filters.

    Category
    Status