Sign upLogin

lokal-profil/mediawiki-extensions-Wikispeech

View on GitHub
Star

Showing 21 of 21 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            for ( ; offset >= 0; offset-- ) {
                for (
                    i = 0;
                    i < self.utterances.length;
                    i++
Severity: Major
Found in modules/ext.wikispeech.storage.js and 1 other location - About 2 hrs to fix
modules/ext.wikispeech.storage.js on lines 937..952

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            for ( ; offset >= 0; offset-- ) {
                for ( i = 0; i < utterance.tokens.length; i++ ) {
                    token = utterance.tokens[ i ];
                    if (
                        self.isPointInItems(
Severity: Major
Found in modules/ext.wikispeech.storage.js and 1 other location - About 2 hrs to fix
modules/ext.wikispeech.storage.js on lines 857..876

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function isValidRemoveTags has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function isValidRemoveTags( $removeTags ) {
        if ( !is_array( $removeTags ) ) {
            return false;
        }
        foreach ( $removeTags as $tagName => $rule ) {
Severity: Minor
Found in includes/ApiWikispeech.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addContent has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    private function addContent( $node ) {
        if ( !$node instanceof DOMComment && !$this->matchesRemove( $node ) ) {
            foreach ( $node->childNodes as $child ) {
                if (
                    !self::lastElement( $this->cleanedContent )
Severity: Minor
Found in includes/Cleaner.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function processPageContent has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function processPageContent(
        $displayTitle,
        $pageContent,
        $outputFormats,
        $removeTags,
Severity: Minor
Found in includes/ApiWikispeech.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function matchesRemove has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    private function matchesRemove( $node ) {
        if ( !array_key_exists( $node->nodeName, $this->removeTags ) ) {
            // The node name isn't found in the removal list.
            return false;
        }
Severity: Minor
Found in includes/Cleaner.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addSegment has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    private function addSegment( $text, $startOffset=0 ) {
        if ( $this->currentSegment['startOffset'] === null ) {
            // Move the start offset ahead by the number of leading
            // whitespaces. This means that whitespaces before or
            // between segments aren't included.
Severity: Minor
Found in includes/Segmenter.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        this.setPlayStopIconToStop = function () {
            $( '.ext-wikispeech-play-stop' ).addClass( 'ext-wikispeech-stop' );
            $( '.ext-wikispeech-play-stop' )
                .removeClass( 'ext-wikispeech-play' );
        };
Severity: Minor
Found in modules/ext.wikispeech.ui.js and 1 other location - About 45 mins to fix
modules/ext.wikispeech.ui.js on lines 212..216

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        this.setPlayStopIconToPlay = function () {
            $( '.ext-wikispeech-play-stop' ).addClass( 'ext-wikispeech-play' );
            $( '.ext-wikispeech-play-stop' )
                .removeClass( 'ext-wikispeech-stop' );
        };
Severity: Minor
Found in modules/ext.wikispeech.ui.js and 1 other location - About 45 mins to fix
modules/ext.wikispeech.ui.js on lines 202..206

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

                        if ( offset <= maxOffset ) {
                            // For the last node, check if position is
                            // before end of utterance.
                            return true;
                        }
Severity: Major
Found in modules/ext.wikispeech.storage.js - About 45 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (
                startNode.nodeType === 3 &&
                    startRange.startOffset === startNode.textContent.length
            ) {
                // Check if start offset is beyond the end of the text node.
    Severity: Minor
    Found in modules/ext.wikispeech.selectionPlayer.js and 1 other location - About 40 mins to fix
    modules/ext.wikispeech.selectionPlayer.js on lines 220..236

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (
                endNode.nodeType === 3 &&
                    endRange.endOffset === 0
            ) {
                // Check if end offset is zero. This is needed
    Severity: Minor
    Found in modules/ext.wikispeech.selectionPlayer.js and 1 other location - About 40 mins to fix
    modules/ext.wikispeech.selectionPlayer.js on lines 92..108

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method processPageContent has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $displayTitle,
        $pageContent,
        $outputFormats,
        $removeTags,
        $segmentBreakingTags
    Severity: Minor
    Found in includes/ApiWikispeech.php - About 35 mins to fix

      Function isPointInItems has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                  node,
            items,
            offset,
            minOffset,
            maxOffset
      Severity: Minor
      Found in modules/ext.wikispeech.storage.js - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        for ( i = node.childNodes.length - 1; i >= 0; i-- ) {
                    // Check children if the given node is an element.
                    child = node.childNodes[ i ];
                    textNode = self.getLastTextNode( child, inUtterance );
                    if ( textNode ) {
        Severity: Minor
        Found in modules/ext.wikispeech.storage.js and 1 other location - About 35 mins to fix
        modules/ext.wikispeech.storage.js on lines 570..577

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        for ( i = 0; i < node.childNodes.length; i++ ) {
                    // Check children if the given node is an element.
                    child = node.childNodes[ i ];
                    textNode = self.getFirstTextNode( child, inUtterance );
                    if ( textNode ) {
        Severity: Minor
        Found in modules/ext.wikispeech.storage.js and 1 other location - About 35 mins to fix
        modules/ext.wikispeech.storage.js on lines 826..833

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this method.
        Open

                return true;
        Severity: Major
        Found in includes/ApiWikispeech.php - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                              return false;
          Severity: Major
          Found in modules/ext.wikispeech.ui.js - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return false;
            Severity: Major
            Found in includes/Cleaner.php - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return false;
              Severity: Major
              Found in modules/ext.wikispeech.storage.js - About 30 mins to fix
                Severity
                Category
                Status
                Source
                Language