Sign upLogin

longitude-one/geo-parser

View on GitHub
Star
lib/LongitudeOne/Geo/String/Parser.php

Summary

Maintainability
B
5 hrs
Test Coverage
A
100%

Method cardinal has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function cardinal(int|float $value): int|float
    {
        // If the cardinal direction was not on the previous coordinate, it can be anything
        if (null === $this->nextCardinal) {
            $this->nextCardinal = Lexer::T_CARDINAL_LON === $this->lexer->lookahead?->type ? Lexer::T_CARDINAL_LON : Lexer::T_CARDINAL_LAT;
Severity: Minor
Found in lib/LongitudeOne/Geo/String/Parser.php - About 1 hr to fix

    Function minutes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        private function minutes(): string|int
    {
        // If using colon or minutes is an integer parse value
        if (Lexer::T_COLON === $this->nextSymbol || $this->lexer->isNextToken(Lexer::T_INTEGER)) {
            /** @var int $readMinutes */
    Severity: Minor
    Found in lib/LongitudeOne/Geo/String/Parser.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function degrees has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function degrees(): float|int
    {
        // Reset symbol requirement
        if (Lexer::T_APOSTROPHE === $this->nextSymbol || Lexer::T_QUOTE === $this->nextSymbol) {
            $this->nextSymbol = Lexer::T_DEGREE;
    Severity: Minor
    Found in lib/LongitudeOne/Geo/String/Parser.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function cardinal has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private function cardinal(int|float $value): int|float
    {
        // If the cardinal direction was not on the previous coordinate, it can be anything
        if (null === $this->nextCardinal) {
            $this->nextCardinal = Lexer::T_CARDINAL_LON === $this->lexer->lookahead?->type ? Lexer::T_CARDINAL_LON : Lexer::T_CARDINAL_LAT;
    Severity: Minor
    Found in lib/LongitudeOne/Geo/String/Parser.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                    return $this->nextSymbol;
    Severity: Major
    Found in lib/LongitudeOne/Geo/String/Parser.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return $this->nextSymbol = false;
      Severity: Major
      Found in lib/LongitudeOne/Geo/String/Parser.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $this->nextSymbol = Lexer::T_QUOTE;
        Severity: Major
        Found in lib/LongitudeOne/Geo/String/Parser.php - About 30 mins to fix

          Function coordinate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function coordinate(): float|int
    {
        // By default, don't change sign
        $sign = false;
          Severity: Minor
          Found in lib/LongitudeOne/Geo/String/Parser.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          CASE statements must be defined using a colon
          Open

                      case 's':
          Severity: Minor
          Found in lib/LongitudeOne/Geo/String/Parser.php by phpcodesniffer

          Line exceeds 120 characters; contains 139 characters
          Open

                      $this->nextCardinal = Lexer::T_CARDINAL_LON === $this->lexer->lookahead?->type ? Lexer::T_CARDINAL_LON : Lexer::T_CARDINAL_LAT;
          Severity: Minor
          Found in lib/LongitudeOne/Geo/String/Parser.php by phpcodesniffer

          Line exceeds 120 characters; contains 182 characters
          Open

                  if (Lexer::T_COLON !== $this->nextSymbol && $this->lexer->isNextTokenAny([Lexer::T_INTEGER, Lexer::T_FLOAT]) && isset($glimpse->type) && Lexer::T_DEGREE === $glimpse->type) {
          Severity: Minor
          Found in lib/LongitudeOne/Geo/String/Parser.php by phpcodesniffer

          Line exceeds 120 characters; contains 173 characters
          Open

                  if (false === $sign && ($this->nextCardinal > 0 || (null === $this->nextCardinal && $this->lexer->isNextTokenAny([Lexer::T_CARDINAL_LAT, Lexer::T_CARDINAL_LON])))) {
          Severity: Minor
          Found in lib/LongitudeOne/Geo/String/Parser.php by phpcodesniffer

          Line exceeds 120 characters; contains 167 characters
          Open

                  // If a colon hasn't been matched, and next token is a number followed by degree symbol, when tuple separator is space instead of comma, this value is complete
          Severity: Minor
          Found in lib/LongitudeOne/Geo/String/Parser.php by phpcodesniffer

          There are no issues that match your filters.

          Category
          Status