lovata/oc-toolbox-plugin

View on GitHub
classes/component/ComponentSubmitForm.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method getModeProperty has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function getModeProperty()
    {
        $arResult = [
            self::PROPERTY_MODE        => [
                'title'   => 'lovata.toolbox::lang.component.property_mode',
Severity: Minor
Found in classes/component/ComponentSubmitForm.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                return Redirect::to('/');
    Severity: Major
    Found in classes/component/ComponentSubmitForm.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return Redirect::to($sRedirectURL);
      Severity: Major
      Found in classes/component/ComponentSubmitForm.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return Redirect::to('/');
        Severity: Major
        Found in classes/component/ComponentSubmitForm.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return Redirect::to($sRedirectURL);
          Severity: Major
          Found in classes/component/ComponentSubmitForm.php - About 30 mins to fix

            Function getResponseModeForm has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function getResponseModeForm($sRedirectURL = null)
                {
                    if (!Result::status() && !empty($sRedirectURL)) {
                        return Redirect::to($sRedirectURL)->withInput()->with(Result::get());
                    } elseif (!Result::status()) {
            Severity: Minor
            Found in classes/component/ComponentSubmitForm.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getResponseModeAjax has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function getResponseModeAjax($sRedirectURL = null)
                {
                    $this->sendFlashMessage();
            
                    if (!Result::status() && !empty($sRedirectURL)) {
            Severity: Minor
            Found in classes/component/ComponentSubmitForm.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Reduce the number of returns of this function 6, down to the maximum allowed 3.
            Open

                protected function getResponseModeForm($sRedirectURL = null)

            Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

            Noncompliant Code Example

            With the default threshold of 3:

            function myFunction(){ // Noncompliant as there are 4 return statements
              if (condition1) {
                return true;
              } else {
                if (condition2) {
                  return false;
                } else {
                  return true;
                }
              }
              return false;
            }
            

            Reduce the number of returns of this function 6, down to the maximum allowed 3.
            Open

                protected function getResponseModeAjax($sRedirectURL = null)

            Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

            Noncompliant Code Example

            With the default threshold of 3:

            function myFunction(){ // Noncompliant as there are 4 return statements
              if (condition1) {
                return true;
              } else {
                if (condition2) {
                  return false;
                } else {
                  return true;
                }
              }
              return false;
            }
            

            Define a constant instead of duplicating this literal "title" 4 times.
            Wontfix

                            'title'   => 'lovata.toolbox::lang.component.property_mode',

            Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

            On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

            Noncompliant Code Example

            With the default threshold of 3:

            function run() {
              prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
              execute('action1');
              release('action1');
            }
            

            Compliant Solution

            ACTION_1 = 'action1';
            
            function run() {
              prepare(ACTION_1);
              execute(ACTION_1);
              release(ACTION_1);
            }
            

            Exceptions

            To prevent generating some false-positives, literals having less than 5 characters are excluded.

            Abstract class name is not prefixed with "Abstract"
            Wontfix

            abstract class ComponentSubmitForm extends ComponentBase

            There are no issues that match your filters.

            Category
            Status