classes/component/ElementPage.php
Function hasRelationWithSite has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
protected function hasRelationWithSite($obEntity): bool
{
if (empty($obEntity)) {
return false;
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this method. Open
Open
return false;Reduce the number of returns of this function 5, down to the maximum allowed 3. Open
Open
protected function hasRelationWithSite($obEntity): bool- Read upRead up
- Exclude checks
Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.
Noncompliant Code Example
With the default threshold of 3:
function myFunction(){ // Noncompliant as there are 4 return statements
if (condition1) {
return true;
} else {
if (condition2) {
return false;
} else {
return true;
}
}
return false;
}
Abstract class name is not prefixed with "Abstract" Wontfix
Wontfix
abstract class ElementPage extends ComponentBase- Exclude checks