Sign upLogin

lovata/oc-toolbox-plugin

View on GitHub
Star
classes/console/ToolBoxHelper.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method handle has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function handle()
    {
        $this->logoToolBox();

        $arHeaderList = [self::HEADER_COMMAND_LIST, self::HEADER_DESCRIPTION];
Severity: Major
Found in classes/console/ToolBoxHelper.php - About 3 hrs to fix

    Define a constant instead of duplicating this literal "lovata.toolbox::lang.message.table_toolbox_create" 17 times.
    Open

                    Lang::get('lovata.toolbox::lang.message.table_toolbox_create', ['description' => 'all pack.']),
    Severity: Critical
    Found in classes/console/ToolBoxHelper.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "description" 17 times.
    Open

                    Lang::get('lovata.toolbox::lang.message.table_toolbox_create', ['description' => 'all pack.']),
    Severity: Critical
    Found in classes/console/ToolBoxHelper.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    There are no issues that match your filters.

    Category
    Status