lovata/oc-toolbox-plugin

View on GitHub
classes/helper/ImportXMLNode.php

Summary

Maintainability
A
30 mins
Test Coverage

Avoid too many return statements within this method.
Open

        return $arResult;
Severity: Major
Found in classes/helper/ImportXMLNode.php - About 30 mins to fix

    Reduce the number of returns of this function 5, down to the maximum allowed 3.
    Open

        public function getValueByPath($sFieldPath, $sPrefix = null, $sNamespace = null)
    Severity: Major
    Found in classes/helper/ImportXMLNode.php by sonar-php

    Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

    Noncompliant Code Example

    With the default threshold of 3:

    function myFunction(){ // Noncompliant as there are 4 return statements
      if (condition1) {
        return true;
      } else {
        if (condition2) {
          return false;
        } else {
          return true;
        }
      }
      return false;
    }
    

    Superfluous parameter comment
    Open

         * @param string|null       $sNamespace

    Doc comment for parameter $sFieldPath does not match actual variable name $sPrefix
    Open

         * @param string            $sFieldPath

    Doc comment for parameter $obNode does not match actual variable name $sFieldPath
    Open

         * @param \SimpleXMLElement $obNode

    Doc comment for parameter $sPrefix does not match actual variable name $sNamespace
    Open

         * @param string|null       $sPrefix

    There are no issues that match your filters.

    Category
    Status