classes/helper/ImportXMLNode.php
Avoid too many return
statements within this method. Open
Open
return $arResult;
Reduce the number of returns of this function 5, down to the maximum allowed 3. Open
Open
public function getValueByPath($sFieldPath, $sPrefix = null, $sNamespace = null)
- Read upRead up
- Exclude checks
Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.
Noncompliant Code Example
With the default threshold of 3:
function myFunction(){ // Noncompliant as there are 4 return statements if (condition1) { return true; } else { if (condition2) { return false; } else { return true; } } return false; }
Superfluous parameter comment Open
Open
* @param string|null $sNamespace
- Exclude checks
Doc comment for parameter $sFieldPath does not match actual variable name $sPrefix Open
Open
* @param string $sFieldPath
- Exclude checks
Doc comment for parameter $obNode does not match actual variable name $sFieldPath Open
Open
* @param \SimpleXMLElement $obNode
- Exclude checks
Doc comment for parameter $sPrefix does not match actual variable name $sNamespace Open
Open
* @param string|null $sPrefix
- Exclude checks