lovata/oc-toolbox-plugin

View on GitHub
classes/item/MainItem.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function getRelationField has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getRelationField($sName, $arRelationData)
    {
        //Check relation config data
        if (empty($sName) || empty($arRelationData) || !is_array($arRelationData)) {
            return null;
Severity: Minor
Found in classes/item/MainItem.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __get has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function __get($sName)
    {
        //Get relation field value
        if (!empty($this->arRelationList) && isset($this->arRelationList[$sName])) {
            return $this->getRelationField($sName, $this->arRelationList[$sName]);
Severity: Minor
Found in classes/item/MainItem.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return $this->getAttribute($sName);
Severity: Major
Found in classes/item/MainItem.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return $this->getAttribute($sName);
    Severity: Major
    Found in classes/item/MainItem.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return $this->getLangAttribute($sName);
      Severity: Major
      Found in classes/item/MainItem.php - About 30 mins to fix

        The method getRelationField() has an NPath complexity of 216. The configured NPath complexity threshold is 200.
        Open

            protected function getRelationField($sName, $arRelationData)
            {
                //Check relation config data
                if (empty($sName) || empty($arRelationData) || !is_array($arRelationData)) {
                    return null;
        Severity: Minor
        Found in classes/item/MainItem.php by phpmd

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
            function bar() {
                // lots of complicated code
            }
        }

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The method getRelationField() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
        Open

            protected function getRelationField($sName, $arRelationData)
            {
                //Check relation config data
                if (empty($sName) || empty($arRelationData) || !is_array($arRelationData)) {
                    return null;
        Severity: Minor
        Found in classes/item/MainItem.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        Reduce the number of returns of this function 6, down to the maximum allowed 3.
        Open

            public function __get($sName)
        Severity: Major
        Found in classes/item/MainItem.php by sonar-php

        Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

        Noncompliant Code Example

        With the default threshold of 3:

        function myFunction(){ // Noncompliant as there are 4 return statements
          if (condition1) {
            return true;
          } else {
            if (condition2) {
              return false;
            } else {
              return true;
            }
          }
          return false;
        }
        

        Reduce the number of returns of this function 4, down to the maximum allowed 3.
        Open

            public function getLangAttribute($sName, $sLangCode = null)
        Severity: Major
        Found in classes/item/MainItem.php by sonar-php

        Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

        Noncompliant Code Example

        With the default threshold of 3:

        function myFunction(){ // Noncompliant as there are 4 return statements
          if (condition1) {
            return true;
          } else {
            if (condition2) {
              return false;
            } else {
              return true;
            }
          }
          return false;
        }
        

        Reduce the number of returns of this function 5, down to the maximum allowed 3.
        Open

            protected function getRelationField($sName, $arRelationData)
        Severity: Major
        Found in classes/item/MainItem.php by sonar-php

        Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

        Noncompliant Code Example

        With the default threshold of 3:

        function myFunction(){ // Noncompliant as there are 4 return statements
          if (condition1) {
            return true;
          } else {
            if (condition2) {
              return false;
            } else {
              return true;
            }
          }
          return false;
        }
        

        Abstract class name is not prefixed with "Abstract"
        Open

        abstract class MainItem implements CallsAnyMethod
        Severity: Minor
        Found in classes/item/MainItem.php by phpcodesniffer

        Variable "disk_name" is not in valid camel caps format
        Open

                $obFile->disk_name = array_get($arFileData, 'disk_name');
        Severity: Minor
        Found in classes/item/MainItem.php by phpcodesniffer

        There are no issues that match your filters.

        Category
        Status