lovata/oc-toolbox-plugin

View on GitHub
models/CommonSettings.php

Summary

Maintainability
A
30 mins
Test Coverage

Avoid too many return statements within this method.
Open

        return $sValue;
Severity: Major
Found in models/CommonSettings.php - About 30 mins to fix

    Reduce the number of returns of this function 5, down to the maximum allowed 3.
    Open

        public static function getValue($sCode, $sDefaultValue = null)
    Severity: Major
    Found in models/CommonSettings.php by sonar-php

    Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

    Noncompliant Code Example

    With the default threshold of 3:

    function myFunction(){ // Noncompliant as there are 4 return statements
      if (condition1) {
        return true;
      } else {
        if (condition2) {
          return false;
        } else {
          return true;
        }
      }
      return false;
    }
    

    There are no issues that match your filters.

    Category
    Status