Sign upLogin

lter/deims

View on GitHub
Star

Showing 699 of 699 total issues

Expected 2 space(s) before asterisk; 1 found
Open

 *
Severity: Minor
Found in modules/custom/iso/templates/iso.tpl.php by phpcodesniffer

There must be no blank lines after the function comment
Open

 */
Severity: Minor
Found in modules/custom/eml_harvest_list/eml_harvest_list.module by phpcodesniffer

Missing function doc comment
Open

  public function __construct($node) {
Severity: Minor
Found in modules/custom/iso/lib/IsoDataSet.php by phpcodesniffer

Expected 2 space(s) before asterisk; 1 found
Open

 * @file
Severity: Minor
Found in modules/custom/iso/templates/iso.tpl.php by phpcodesniffer

There must be exactly one blank line before the tags in a doc comment
Open

 * @see http://api.drupal.org/api/drupal/modules%21node%21node.module/function/node_feed/7
Severity: Minor
Found in modules/custom/eml_harvest_list/eml_harvest_list.pages.inc by phpcodesniffer

Missing function doc comment
Open

  public function __construct($node) {
Severity: Minor
Found in modules/custom/eml_harvest_list/lib/EmlHarvestList.php by phpcodesniffer

The PHP open tag must be followed by exactly one blank line
Open

<?php
Severity: Minor
Found in modules/custom/eml_harvest_list/templates/eml_hl.tpl.php by phpcodesniffer

Missing function doc comment
Open

function _iso_date_value($date, $granularity) {
Severity: Minor
Found in modules/custom/iso/iso.field.inc by phpcodesniffer

Doc comment short description must be on a single line, further text should be a separate paragraph
Open

 * by other elements.
Severity: Minor
Found in modules/custom/iso/templates/iso--node--person.tpl.php by phpcodesniffer

Missing class doc comment
Open

class LterUnitHelper {
Severity: Minor
Found in modules/custom/lter_unit/lib/LterUnitHelper.php by phpcodesniffer

Function fetchEmlReport has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  public function fetchEmlReport() {

    list($scope, $identifier, $revision) = $this->dataSet->getPackageIDParts();

    // Fetch the EML report from the API.
Severity: Minor
Found in modules/custom/pasta/lib/PastaApi.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Public method name "EmlHarvestList::getEMLHL" is not in lowerCamel format
Open

  public function getEMLHL($reset = FALSE) {
Severity: Minor
Found in modules/custom/eml_harvest_list/lib/EmlHarvestList.php by phpcodesniffer

Expected 2 space(s) before asterisk; 1 found
Open

 *  Default template to use when an entity is rendered using the 'iso' view mode.
Severity: Minor
Found in modules/custom/iso/templates/iso.tpl.php by phpcodesniffer

Additional blank lines found at end of doc comment
Open

   */
Severity: Minor
Found in modules/custom/lter_unit/lib/LterUnitStmmlHelper.php by phpcodesniffer

Missing function doc comment
Open

  public function submitEml() {
Severity: Minor
Found in modules/custom/pasta/lib/PastaApi.php by phpcodesniffer

Closing brace indented incorrectly; expected 2 spaces, found 0
Open

}
Severity: Minor
Found in modules/custom/pasta/lib/PastaApi.php by phpcodesniffer

Public method name "PastaApi::fetchDOI" is not in lowerCamel format
Open

  public function fetchDOI() {
Severity: Minor
Found in modules/custom/pasta/lib/PastaApi.php by phpcodesniffer

Expected 2 space(s) before asterisk; 3 found
Open

   *   An integer from the PASTA API.
Severity: Minor
Found in modules/custom/pasta/lib/PastaApi.php by phpcodesniffer

Line indented incorrectly; expected 10 spaces, found 11
Open

           $element[$delta] = array(
Severity: Minor
Found in modules/custom/bdp/bdp.field.inc by phpcodesniffer

Expected 1 space(s) before asterisk; 2 found
Open

  * Implement hook_help()
Severity: Minor
Found in modules/custom/pasta/get_doi/get_doi.module by phpcodesniffer
Severity
Category
Status
Source
Language