modules/custom/bdp/bdp.field.inc
The function bdp_field_formatter_view() has 240 lines of code. Current threshold is set to 100. Avoid really long methods. Open
Open
function bdp_field_formatter_view($entity_type, $entity, $field, $instance, $langcode, $items, $display) {
$element = array();
$settings = $display['settings'];
switch ($display['type']) {- Exclude checks
The function bdp_field_formatter_view() has a Cyclomatic Complexity of 48. The configured cyclomatic complexity threshold is 10. Open
Open
function bdp_field_formatter_view($entity_type, $entity, $field, $instance, $langcode, $items, $display) {
$element = array();
$settings = $display['settings'];
switch ($display['type']) {- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Line indented incorrectly; expected 10 spaces, found 11 Open
Open
$element[$delta] = array(- Exclude checks
Line indented incorrectly; expected 10 spaces, found 11 Open
Open
$element[$delta] = array(- Exclude checks
Array indentation error, expected 12 spaces but found 16 Open
Open
'begdate' => _bdp_date_value($dates['value'], $granularity),- Exclude checks
Array closing indentation error, expected 10 spaces but found 14 Open
Open
)- Exclude checks
The first index in a multi-value array must be on a new line Open
Open
$value = array('key' => 'rngdates', 'value' => array(- Exclude checks
Array indentation error, expected 12 spaces but found 16 Open
Open
'enddate' => _bdp_date_value($dates['value2'], $granularity),- Exclude checks
The first index in a multi-value array must be on a new line Open
Open
$value = array('key' => 'rngdates', 'value' => array(- Exclude checks
If the line declaring an array spans longer than 80 characters, each element should be broken into its own line Open
Open
$value = array('key' => 'sngdate', 'value' => _bdp_date_value($dates['value'], $granularity));- Exclude checks
Array closing indentation error, expected 10 spaces but found 12 Open
Open
)- Exclude checks
Missing function doc comment Open
Open
function _bdp_date_value($date, $granularity) {- Exclude checks
Array closing indentation error, expected 10 spaces but found 11 Open
Open
)- Exclude checks