modules/custom/bdp/bdp.module
template_preprocess_bdp accesses the super-global variable $GLOBALS. Open
Open
function template_preprocess_bdp(&$variables, $hook) {
$variables['entity'] = $variables['elements']['#entity'];
$entity = $variables['entity'];
$entity_type = $variables['elements']['#entity_type'];
$bundle = $variables['elements']['#bundle'];- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
The function bdp_node_view() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10. Open
Open
function bdp_node_view($node, $view_mode, $langcode) {
if ($view_mode != 'bdp') {
return;
}
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing function doc comment Open
Open
function bdp_debug($message, array $variables = array()) {- Exclude checks
Missing function doc comment Open
Open
function theme_bdp_elements($variables) {- Exclude checks
Missing function doc comment Open
Open
function theme_bdp_tags($variables) {- Exclude checks
Missing function doc comment Open
Open
function theme_bdp_tag($variables) {- Exclude checks
Doc comment long description must end with a full stop Open
Open
* BDP view mode and template for nodes- Exclude checks