modules/custom/deims_data_explorer/deims_data_explorer.module
The function deims_data_explorer_get_query_from_data_source() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
Open
function deims_data_explorer_get_query_from_data_source($node, array $columns = array(), array $filters = array()) {
if ($node->type == 'data_source' && $connection = field_get_items('node', $node, DEIMS_DATA_EXPLORER_FIELD)) {
if (!empty($connection[0]['connection']) && !empty($connection[0]['table'])) {
try {
// Database::getConnection() could throw an exception so catch it and- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
The function deims_data_explorer_filters_apply() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
Open
function deims_data_explorer_filters_apply(QueryAlterableInterface $query, array $filters) {
foreach ($filters as $key => $filter) {
switch ($filter['variable']['type']) {
case '';
if (drupal_strlen($filter['value'])) {- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Avoid unused local variables such as '$file'. Open
Open
foreach ($files as $filepath => $file) { - Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
No space found before comment text; expected "// );" but found "//);" Open
Open
//);- Exclude checks
Inline comments must end in full-stops, exclamation marks, colons, question marks, or closing parentheses Open
Open
//);- Exclude checks
Missing function doc comment Open
Open
function deims_data_explorer_filters_apply(QueryAlterableInterface $query, array $filters) {- Exclude checks
No space found before comment text; expected "// );" but found "//);" Open
Open
//);- Exclude checks
Comment indentation error, expected only 1 spaces Open
Open
// 'title' => t('Use the DEIMS data explorer'),- Exclude checks
Comment indentation error, expected only 1 spaces Open
Open
// 'title' => t('Administer DEIMS data explorer'),- Exclude checks
Inline comments must end in full-stops, exclamation marks, colons, question marks, or closing parentheses Open
Open
//);- Exclude checks
Type hint "array" missing for $variable Open
Open
function deims_data_explorer_filter_allowed_column_variable($variable) {- Exclude checks
Whitespace found at end of line Open
Open
foreach ($files as $filepath => $file) { - Exclude checks