modules/custom/eml/eml.field.inc

Summary

Maintainability
Test Coverage

The function eml_field_formatter_view() has 202 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

function eml_field_formatter_view($entity_type, $entity, $field, $instance, $langcode, $items, $display) {
  $element = array();
  $settings = $display['settings'];

  switch ($display['type']) {
Severity: Minor
Found in modules/custom/eml/eml.field.inc by phpmd

The function eml_field_formatter_view() has a Cyclomatic Complexity of 39. The configured cyclomatic complexity threshold is 10.
Open

function eml_field_formatter_view($entity_type, $entity, $field, $instance, $langcode, $items, $display) {
  $element = array();
  $settings = $display['settings'];

  switch ($display['type']) {
Severity: Minor
Found in modules/custom/eml/eml.field.inc by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Array closing indentation error, expected 12 spaces but found 13
Open

             )

Closing parenthesis of array declaration must be on a new line
Open

          )),

Missing function doc comment
Open

function _eml_date_value($date, $granularity) {

Concat operator must be surrounded by a single space
Open

          $address['deliveryPoint'] = $address['deliveryPoint'].", ".$item['premise'];  

Each index in a multi-line array must be on a new line
Open

            'key' => 'rangeOfDates', 'value' => array(

Concat operator must be surrounded by a single space
Open

          $address['deliveryPoint'] = $address['deliveryPoint'].", ".$item['premise'];  

Whitespace found at end of line
Open

          $address['deliveryPoint'] = $address['deliveryPoint'].", ".$item['premise'];  

Whitespace found at end of line
Open

            'key' => 'singleDateTime', 

Whitespace found at end of line
Open

        }        

There are no issues that match your filters.

Category
Status