modules/custom/lter_unit/lib/LterUnitHelper.php

Summary

Maintainability
C
1 day
Test Coverage

getUnitOptions accesses the super-global variable $GLOBALS.
Open

  public static function getUnitOptions($category_minimum = 0) {
    $results = &drupal_static(__FUNCTION__);

    if (!isset($results)) {
      $cid = 'unit-options:' . $GLOBALS['language']->language;

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Function getUnitOptions has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

  public static function getUnitOptions($category_minimum = 0) {
    $results = &drupal_static(__FUNCTION__);

    if (!isset($results)) {
      $cid = 'unit-options:' . $GLOBALS['language']->language;
Severity: Minor
Found in modules/custom/lter_unit/lib/LterUnitHelper.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getUnits has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  public static function getUnits() {
    $units = &drupal_static(__FUNCTION__);

    if (!isset($units)) {
      $cid = 'units:scope=2';
Severity: Minor
Found in modules/custom/lter_unit/lib/LterUnitHelper.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getUnitOptions has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public static function getUnitOptions($category_minimum = 0) {
    $results = &drupal_static(__FUNCTION__);

    if (!isset($results)) {
      $cid = 'unit-options:' . $GLOBALS['language']->language;
Severity: Minor
Found in modules/custom/lter_unit/lib/LterUnitHelper.php - About 1 hr to fix

    Method getUnits has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public static function getUnits() {
        $units = &drupal_static(__FUNCTION__);
    
        if (!isset($units)) {
          $cid = 'units:scope=2';
    Severity: Minor
    Found in modules/custom/lter_unit/lib/LterUnitHelper.php - About 1 hr to fix

      The method getUnitOptions() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
      Open

        public static function getUnitOptions($category_minimum = 0) {
          $results = &drupal_static(__FUNCTION__);
      
          if (!isset($results)) {
            $cid = 'unit-options:' . $GLOBALS['language']->language;

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Missing class doc comment
      Open

      class LterUnitHelper {

      The closing brace for the class must have an empty line before it
      Open

      }

      Missing function doc comment
      Open

        public static function isUnitStandard($unit) {

      Expected 1 blank line after function; 0 found
      Open

        }

      There are no issues that match your filters.

      Category
      Status