modules/custom/pasta/lib/PastaSubmissionQueue.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function processData has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  public static function processData(&$data) {
    try {
      if ($node = node_load($data['nid'])) {
        $dataset = new EmlDataSet($node);
        $pasta = new PastaApi($dataset);
Severity: Minor
Found in modules/custom/pasta/lib/PastaSubmissionQueue.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method processData has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public static function processData(&$data) {
    try {
      if ($node = node_load($data['nid'])) {
        $dataset = new EmlDataSet($node);
        $pasta = new PastaApi($dataset);
Severity: Minor
Found in modules/custom/pasta/lib/PastaSubmissionQueue.php - About 1 hr to fix

    The method processData() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
    Open

      public static function processData(&$data) {
        try {
          if ($node = node_load($data['nid'])) {
            $dataset = new EmlDataSet($node);
            $pasta = new PastaApi($dataset);

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    Missing function doc comment
    Open

      public static function get($name = 'PastaSubmissionQueue') {

    Expected 1 blank line before function; 0 found
    Open

      public static function get($name = 'PastaSubmissionQueue') {

    Missing class doc comment
    Open

    class PastaSubmissionQueue extends SystemQueue {

    Expected 1 blank line after function; 0 found
    Open

      }

    The closing brace for the class must have an empty line before it
    Open

    }

    Missing function doc comment
    Open

      public static function processData(&$data) {

    Missing function doc comment
    Open

      public function enqueue($node) {

    There are no issues that match your filters.

    Category
    Status