Avoid unused local variables such as '$revision'. Open
list($scope, $identifier, $revision) = $this->dataSet->getPackageIDParts();
- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function fetchEMLID() {
list($scope, $identifier, $revision) = $this->dataSet->getPackageIDParts();
$url = static::getApiUrl("package/eml/{$scope}/{$identifier}?filter=newest");
$request = drupal_http_request($url, array('timeout' => 10));
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 166.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Missing function doc comment Open
public static function getApiUrl($path, array $options = array()) {
- Exclude checks
Public method name "PastaEmlIdApi::fetchEMLID" is not in lowerCamel format Open
public function fetchEMLID() {
- Exclude checks
Missing class doc comment Open
class PastaEmlIdApi {
- Exclude checks
Line indented incorrectly; expected 6 spaces, found 8 Open
return $request->data;
- Exclude checks
Separate the @throws and @ingroup sections by a blank line. Open
* @ingroup eml_data_manager_api
- Exclude checks
Missing function doc comment Open
public function getDataSet() {
- Exclude checks
The closing brace for the class must have an empty line before it Open
}
- Exclude checks
Missing function doc comment Open
public function __construct(EmlDataSet $dataSet) {
- Exclude checks
Expected 1 blank line after function; 0 found Open
}
- Exclude checks