Sign upLogin

lugu/qiloop

View on GitHub
Star
type/object/metaobject_decorator.go

Summary

Maintainability
B
6 hrs
Test Coverage
F
56%

Method MetaObject.SignalID has 5 return statements (exceeds 4 allowed).
Open

func (m *MetaObject) SignalID(name, sig string) (uint32, error) {
    for _, signal := range m.Signals {
        if signal.Name == name &&
            signal.Signature == sig {
            return signal.Uid, nil
Severity: Major
Found in type/object/metaobject_decorator.go - About 35 mins to fix

    Method MetaObject.PropertyID has 5 return statements (exceeds 4 allowed).
    Open

    func (m *MetaObject) PropertyID(name, sig string) (uint32, error) {
    for _, property := range m.Properties {
        if property.Name == name &&
            property.Signature == sig {
            return property.Uid, nil
    Severity: Major
    Found in type/object/metaobject_decorator.go - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (m *MetaObject) SignalID(name, sig string) (uint32, error) {
    for _, signal := range m.Signals {
        if signal.Name == name &&
            signal.Signature == sig {
            return signal.Uid, nil
      Severity: Major
      Found in type/object/metaobject_decorator.go and 1 other location - About 2 hrs to fix
      type/object/metaobject_decorator.go on lines 84..110

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 242.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (m *MetaObject) PropertyID(name, sig string) (uint32, error) {
    for _, property := range m.Properties {
        if property.Name == name &&
            property.Signature == sig {
            return property.Uid, nil
      Severity: Major
      Found in type/object/metaobject_decorator.go and 1 other location - About 2 hrs to fix
      type/object/metaobject_decorator.go on lines 54..78

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 242.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      comment on exported function ReadObjectReference should be of the form "ReadObjectReference ..."
      Open

      // ReadMetaObject serialize an ObjectReference.
      Severity: Minor
      Found in type/object/metaobject_decorator.go by golint

      exported method MetaObject.PropertyName should have comment or be unexported
      Open

      func (m *MetaObject) PropertyName(id uint32) (string, error) {
      Severity: Minor
      Found in type/object/metaobject_decorator.go by golint

      There are no issues that match your filters.

      Category
      Status