lujanfernaud/prevy

View on GitHub

Showing 1,727 of 1,727 total issues

Properties should be ordered border-bottom, right
Open

  right: 15px;

Color literals like #6610f2 should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

  border-bottom: 3px solid #6610f2;

Property background-size already defined on line 156
Open

  background-size: 8px 10px;

Selector sign-up-box__label should be written in lowercase with hyphens
Open

.sign-up-box__label {

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

    unless value =~ VALID_EMAIL_REGEX
Severity: Minor
Found in app/validators/email_validator.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Inconsistent indentation detected.
Open

    def application_name
      Rails.application.class.parent_name.underscore
    end
Severity: Minor
Found in app/uploaders/image_uploader.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    cloudinary_transformation quality: "auto"
Severity: Minor
Found in app/uploaders/image_uploader.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Redundant begin block detected.
Open

  begin
Severity: Minor
Found in bin/yarn by rubocop

This cop checks for redundant begin blocks.

Currently it checks for code like this:

Example:

def redundant
  begin
    ala
    bala
  rescue StandardError => e
    something
  end
end

def preferred
  ala
  bala
rescue StandardError => e
  something
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    $stderr.puts "Yarn executable was not detected in the system."
Severity: Minor
Found in bin/yarn by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem capybara-screenshot should appear before capybara-webkit.
Open

  gem 'capybara-screenshot',           '~> 1.0', '>= 1.0.18'
Severity: Minor
Found in Gemfile by rubocop

Gems should be alphabetically sorted within groups.

Example:

# bad
gem 'rubocop'
gem 'rspec'

# good
gem 'rspec'
gem 'rubocop'

# good
gem 'rubocop'

gem 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
gem 'rubocop'
# For tests
gem 'rspec'

!important should not be used
Open

  border-radius: 100% !important;

Selector box-image__img should be written in lowercase with hyphens
Open

.box-image__img {

!important should not be used
Open

  flex: 0 !important;

Properties should be ordered background-color, padding
Open

  padding: 0 7px 0 7px;

Properties should be ordered border-color, color
Open

  color: white;

Color literals like rgba(white, 0.5) should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

  border-color: rgba(white, .5);

!important should not be used
Open

    border-top-left-radius: $box-radius !important;

!important should not be used
Open

    border-bottom-left-radius: $box-radius !important;

Color literals like #495057 should only be used in variable declarations; they should be referred to via variable everywhere else.
Open

  color: #495057;

Properties should be ordered color, font-size
Open

  font-size: 1.25rem;
Severity
Category
Status
Source
Language