lujanfernaud/prevy

View on GitHub

Showing 1,727 of 1,727 total issues

Properties should be ordered height, margin-bottom, width
Open

    margin-bottom: -33px;

Shorthand form for property padding should be written more concisely as 2.5rem 0 1.5rem instead of 2.5rem 0 1.5rem 0
Open

  padding: 2.5rem 0 1.5rem 0;

Properties should be ordered flex-basis, flex-direction, padding
Open

    flex-direction: row;

Missing top-level class documentation comment.
Open

class UpdatedEventNotifier

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      field_name.remove("updated").gsub("_", " ")

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      field_name.remove("updated").gsub("_", " ")

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Inconsistent indentation detected.
Open

    def model_type
      model.class.to_s.underscore.pluralize
    end
Severity: Minor
Found in app/uploaders/image_uploader.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

%w-literals should be delimited by [ and ].
Open

    %w(jpg jpeg gif png)
Severity: Minor
Found in app/uploaders/image_uploader.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Missing magic comment # frozen_string_literal: true.
Open

# This file is used by Rack-based servers to start the application.
Severity: Minor
Found in config.ru by rubocop

This cop is designed to help upgrade to Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

Example: EnforcedStyle: when_needed (default)

# The `when_needed` style will add the frozen string literal comment
# to files only when the `TargetRubyVersion` is set to 2.3+.
# bad
module Foo
  # ...
end

# good
# frozen_string_literal: true

module Foo
  # ...
end

Example: EnforcedStyle: always

# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

Example: EnforcedStyle: never

# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem figaro should appear before nokogiri.
Open

gem 'figaro',                          '~> 1.1', '>= 1.1.1'
Severity: Minor
Found in Gemfile by rubocop

Gems should be alphabetically sorted within groups.

Example:

# bad
gem 'rubocop'
gem 'rspec'

# good
gem 'rspec'
gem 'rubocop'

# good
gem 'rubocop'

gem 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
gem 'rubocop'
# For tests
gem 'rspec'

Use the new Ruby 1.9 hash syntax.
Open

  gem 'bundler-audit',                 :require => false
Severity: Minor
Found in Gemfile by rubocop

This cop checks hash literal syntax.

It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

A separate offense is registered for each problematic pair.

The supported styles are:

  • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
  • hash_rockets - forces use of hash rockets for all hashes
  • nomixedkeys - simply checks for hashes with mixed syntaxes
  • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

Example: EnforcedStyle: ruby19 (default)

# bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

Example: EnforcedStyle: hash_rockets

# bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

Example: EnforcedStyle: nomixedkeys

# bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

Example: EnforcedStyle: ruby19nomixed_keys

# bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

Commas in function arguments should be followed by one space
Open

  box-shadow: 0 3px 10px rgba(27,31,35,0.2);

Prefer single quoted strings
Open

@import "sections/topics";

Prefer single quoted strings
Open

@import "vendor-modifications/turbolinks";

Properties should be ordered background, border-radius, height, padding-left, position, text-align
Open

  position: relative;

Color #E0E8F0 should be written as #e0e8f0
Open

  background: darken(#E0E8F0, 8%);

Properties should be ordered border-bottom-left-radius, border-top-left-radius
Open

    border-top-left-radius: $box-radius !important;

!important should not be used
Open

  border-bottom: 3px solid $indigo !important;

Properties should be ordered max-width, width
Open

  width: 100%;

Shorthand form for property padding should be written more concisely as 4.5rem 6rem 5.5rem instead of 4.5rem 6rem 5.5rem 6rem
Open

    padding: 4.5rem 6rem 5.5rem 6rem;
Severity
Category
Status
Source
Language