Sign upLogin

lukepolo/laracart

View on GitHub
Star
src/CartItem.php

Summary

Maintainability
D
1 day
Test Coverage
A
91%

Function taxSummary has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

    public function taxSummary()
    {
        $taxed = [];
        // tax item by item
        for ($qty = 0; $qty < $this->qty; $qty++) {
Severity: Minor
Found in src/CartItem.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

CartItem has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

class CartItem
{
    const ITEM_ID = 'id';
    const ITEM_QTY = 'qty';
    const ITEM_TAX = 'tax';
Severity: Minor
Found in src/CartItem.php - About 2 hrs to fix

    Method taxSummary has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function taxSummary()
    {
        $taxed = [];
        // tax item by item
        for ($qty = 0; $qty < $this->qty; $qty++) {
    Severity: Minor
    Found in src/CartItem.php - About 1 hr to fix

      Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct($id, $name, $qty, $price, $options = [], $taxable = true, $lineItem = false)
      Severity: Major
      Found in src/CartItem.php - About 50 mins to fix

        There are no issues that match your filters.

        Category
        Status