lulibrary/preservation

View on GitHub
lib/preservation/report/transfer.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method row_to_hash has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def self.row_to_hash(row)
        id = row['id']
        uuid = row['uuid']
        # Archivematica stores path as BLOB, so need to convert path to Hex, to search for it
        # and use hex function in DB query
Severity: Minor
Found in lib/preservation/report/transfer.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method pending has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def self.pending
        entries = Dir.entries Preservation.ingest_path
        dirs = []
        entries.each do |entry|
          path = File.join(Preservation.ingest_path, entry)
Severity: Minor
Found in lib/preservation/report/transfer.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status