Sign upLogin

lulibrary/preservation

View on GitHub
Star
lib/preservation/transfer/dataset.rb

Summary

Maintainability
D
2 days
Test Coverage

Method package_metadata has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

      def package_metadata(d, f)
          o = {}
          o['filename'] = 'objects/' + f.name
          o['dc.title'] = d.title
          if d.description
Severity: Minor
Found in lib/preservation/transfer/dataset.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method package_metadata has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def package_metadata(d, f)
          o = {}
          o['filename'] = 'objects/' + f.name
          o['dc.title'] = d.title
          if d.description
Severity: Major
Found in lib/preservation/transfer/dataset.rb - About 3 hrs to fix

    Method prepare has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

          def prepare(uuid: nil,
                  dir_scheme: :uuid,
                  delay: 0)
        success = false
    Severity: Minor
    Found in lib/preservation/transfer/dataset.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method prepare has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def prepare(uuid: nil,
                  dir_scheme: :uuid,
                  delay: 0)
        success = false
    Severity: Major
    Found in lib/preservation/transfer/dataset.rb - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

              if !dir_name.nil? &&
           !dir_name.empty? &&
           !Preservation::Report::Transfer.in_db?(dir_name) &&
           d.doi &&
           !d.files.empty? &&
      Severity: Major
      Found in lib/preservation/transfer/dataset.rb - About 40 mins to fix

        Method prepare_batch has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def prepare_batch(max: nil,
                        dir_scheme: :uuid,
                        delay: 30)
        collection_extractor = Puree::Extractor::Collection.new config:   @config,
                                                                resource: :dataset
        Severity: Minor
        Found in lib/preservation/transfer/dataset.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status