luyadev/luya-module-cms

View on GitHub

Showing 209 of 326 total issues

Method testActionCleanup has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testActionCleanup()
    {
        PageScope::run($this->app, function (PageScope $scope) {
            $scope->createCmsNavFixture([]);
            $scope->createCmsNavItemFixture([]);
Severity: Minor
Found in tests/src/frontend/commands/PageControllerTest.php - About 1 hr to fix

    Method getLink has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getLink()
        {
            // take care of redirect
            if ($this->getType() === 3 && !empty($this->redirectMapData('value'))) {
                // generate convert object to determine correctn usage.
    Severity: Minor
    Found in src/menu/Item.php - About 1 hr to fix

      Function buildList has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          private function buildList(QueryIteratorFilter $iterator, $i = 1)
          {
              // Abort if maxDepth is set & reached
              if ($this->maxDepth !== null && $i >= ($this->maxDepth + 1)) {
                  return "";
      Severity: Minor
      Found in src/widgets/NavTree.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method renderToolbar has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function renderToolbar($event)
          {
              Yii::info('LUYA CMS Toolbar rendering start', __METHOD__);
      
              $props = [];
      Severity: Minor
      Found in src/frontend/base/Controller.php - About 1 hr to fix

        Method testRegisterJsAssets has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function testRegisterJsAssets()
            {
                // Simulate already registered js
                Yii::$app->view->js = [
                    View::POS_READY => [
        Severity: Minor
        Found in tests/src/base/PhpBlockViewTest.php - About 1 hr to fix

          Method testParseRequest has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function testParseRequest()
              {
                  PageScope::run($this->app, function (PageScope $scope) {
                      $this->createAdminGroupFixture(1);
                      $this->createAdminUserFixture();
          Severity: Minor
          Found in tests/src/frontend/components/WebsiteBehaviorUrlRuleTest.php - About 1 hr to fix

            Method createModule has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function createModule($parentNavId, $navContainerId, $langId, $title, $alias, $moduleName, $description, $controllerName, $actionName, array $actionParams): array|int
                {
                    $_errors = [];
            
                    $nav = $this;
            Severity: Minor
            Found in src/models/Nav.php - About 1 hr to fix

              Method bootstrap has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function bootstrap($app)
                  {
                      if ($app->hasModule('cms')) {
                          // load cms url rules
                          $app->on(Application::EVENT_BEFORE_REQUEST, function ($event) {
              Severity: Minor
              Found in src/frontend/Bootstrap.php - About 1 hr to fix

                Method actionCreatePageVersion has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function actionCreatePageVersion()
                    {
                        $fromPageModel = null;
                        $name = Yii::$app->request->post('name');
                        $fromPageId = (int) Yii::$app->request->post('fromPageId');
                Severity: Minor
                Found in src/admin/apis/NavItemController.php - About 1 hr to fix

                  Method run has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function run()
                      {
                          $currentLang = Yii::$app->composition['langShortCode'];
                  
                          $rule = Yii::$app->menu->currentUrlRule;
                  Severity: Minor
                  Found in src/widgets/LangSwitcher.php - About 1 hr to fix

                    Method testActionDeepPageCopyAsTemplateSuccess has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function testActionDeepPageCopyAsTemplateSuccess()
                        {
                            // success
                            PermissionScope::run($this->app, function (PermissionScope $scope) {
                                $this->createAdminLangFixture();
                    Severity: Minor
                    Found in tests/src/admin/apis/NavControllerTest.php - About 1 hr to fix

                      Function actionCleanup has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function actionCleanup()
                          {
                              $delete = [];
                              $this->output("Blocks to delete:");
                              foreach (Block::find()->all() as $block) {
                      Severity: Minor
                      Found in src/frontend/commands/BlockController.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function ensureInputValues has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                          protected function ensureInputValues($event)
                          {
                              // sort index fixture
                      
                              if (!$this->isNewRecord) {
                      Severity: Minor
                      Found in src/models/NavItemPageBlockItem.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function fileArrayUpload has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public static function fileArrayUpload(array|string|null|int $value, $returnObject = false)
                          {
                              if (!empty($value) && is_array($value)) {
                                  $data = [];
                                  foreach ($value as $key => $item) {
                      Severity: Minor
                      Found in src/helpers/BlockHelper.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method testUpdateThemeConfig has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function testUpdateThemeConfig()
                          {
                              Yii::setAlias('@app', Yii::getAlias('@cmstests/tests/data'));
                              $this->fixture->rebuild();
                      
                      
                      Severity: Minor
                      Found in tests/src/admin/importers/ThemeImporterTest.php - About 1 hr to fix

                        Function dropItem has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                $scope.dropItem = function(dragged,dropped,position,element) {
                                    var sortIndex = $scope.$index;
                                    
                                    if (position == 'bottom') {
                                        sortIndex = sortIndex + 1;
                        Severity: Minor
                        Found in src/admin/resources/js/cmsadmin.js - About 1 hr to fix

                          Method getPlaceholder has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public static function getPlaceholder($placeholderVar, $prevId, NavItemPage $navItemPage)
                              {
                                  $nav_item_page_block_item_data = NavItemPageBlockItem::find()
                                      ->select(['id', 'block_id', 'json_config_values', 'json_config_cfg_values', 'nav_item_page_id', 'is_dirty', 'is_hidden', 'variation'])
                                      ->where(['prev_id' => $prevId, 'nav_item_page_id' => $navItemPage->id, 'placeholder_var' => $placeholderVar])
                          Severity: Minor
                          Found in src/models/NavItemPage.php - About 1 hr to fix

                            Method resolveCurrent has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                private function resolveCurrent()
                                {
                                    $requestPath = $this->request->get('path', null);
                            
                                    if (empty($requestPath)) {
                            Severity: Minor
                            Found in src/Menu.php - About 1 hr to fix

                              Function getItem has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                      $scope.getItem = function(langId, navId) {
                                          $http({
                                              url: 'admin/api-cms-navitem/nav-lang-item',
                                              method: "GET",
                                              params: { langId : langId, navId : navId }
                              Severity: Minor
                              Found in src/admin/resources/js/cmsadmin.js - About 1 hr to fix

                                Method createPageItem has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    public function createPageItem($navId, $langId, $title, $alias, $layoutId, $description): array|int
                                    {
                                        $_errors = [];
                                
                                        $navItem = new NavItem();
                                Severity: Minor
                                Found in src/models/Nav.php - About 1 hr to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language