Sign upLogin

luyadev/luya-module-cms

View on GitHub
Star

Showing 326 of 326 total issues

Avoid too many return statements within this method.
Open

            return [
                'item' => $model,
                'typeData' => ($model->nav_item_type == 1) ? NavItemPage::getVersionList($model->id) : $model->getType()->toArray()
            ];
Severity: Major
Found in src/admin/apis/NavItemController.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return $image->toArray();
    Severity: Major
    Found in src/helpers/BlockHelper.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in src/admin/importers/CmslayoutImporter.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                            return false;
        Severity: Major
        Found in src/admin/importers/CmslayoutImporter.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                                  return $this->sendModelError($typeModel);
          Severity: Major
          Found in src/admin/apis/NavItemController.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return $image;
            Severity: Major
            Found in src/helpers/BlockHelper.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return "{$title} (" .$block->droppedPageTitle. ")";
              Severity: Major
              Found in src/models/Log.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return $this->renderContent($content);
                Severity: Major
                Found in src/frontend/controllers/DefaultController.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                      return $converter->getTelephoneLink($converter->value)->getHref();
                  Severity: Major
                  Found in src/menu/Item.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return $link;
                    Severity: Major
                    Found in src/menu/Item.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                          return $converter->getFileLink($converter->value, $converter->target)->getHref();
                      Severity: Major
                      Found in src/menu/Item.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return Yii::$app->urlManager->prependBaseUrl('');
                        Severity: Major
                        Found in src/menu/Item.php - About 30 mins to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function getPrevSibling(): \luya\cms\menu\Item|bool
    {
        return (new Query())
            ->where(['parent_nav_id' => $this->parentNavId, 'container' => $this->container])
            ->andWhere(['<', 'sort_index', $this->sortIndex])
                          Severity: Minor
                          Found in src/menu/Item.php and 1 other location - About 30 mins to fix
                          src/menu/Item.php on lines 625..634

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 90.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function getNextSibling(): \luya\cms\menu\Item|bool
    {
        return (new Query())
            ->where(['parent_nav_id' => $this->parentNavId, 'container' => $this->container])
            ->andWhere(['>', 'sort_index', $this->sortIndex])
                          Severity: Minor
                          Found in src/menu/Item.php and 1 other location - About 30 mins to fix
                          src/menu/Item.php on lines 643..652

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 90.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Function createPage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function createPage($parentNavId, $navContainerId, $langId, $title, $alias, $layoutId, $description, $isDraft = false): array|int
    {
        $_errors = [];

        $nav = $this;
                          Severity: Minor
                          Found in src/models/Nav.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function moduleContent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function moduleContent($moduleName)
    {
        if ($this->isAdminContext() || empty($moduleName) || count($this->getEnvOptions()) === 0 || !Yii::$app->hasModule($moduleName)) {
            return;
        }
                          Severity: Minor
                          Found in src/frontend/blocks/ModuleBlock.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function getLevelContainer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function getLevelContainer($level, Item $baseItem = null): array|\luya\cms\menu\QueryIteratorFilter
    {
        // define if the requested level is the root line (level 1) or not
        $rootLine = ($level === 1) ? true : false;
        // countdown the level (as we need the parent of the element to get the children
                          Severity: Minor
                          Found in src/Menu.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function matchRequestPath has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function matchRequestPath($requestPath): bool|string
    {
        foreach ([$requestPath, urlencode($requestPath), urldecode($requestPath)] as $path) {
            foreach ([$this->catch_path, urlencode($this->catch_path), urldecode($this->catch_path)] as $catch) {
                if ($response = $this->pathMatcher($path, $catch)) {
                          Severity: Minor
                          Found in src/models/Redirect.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function copySubBlocksTo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              private function copySubBlocksTo($sourceId, $targetPrevId, $targetNavItemPageId)
    {
        if ($sourceId) {
            $subBlocks = NavItemPageBlockItem::findAll(['prev_id' => $sourceId]);
            foreach ($subBlocks as $block) {
                          Severity: Minor
                          Found in src/admin/apis/NavItemBlockController.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function actionDeepPageCopyAsTemplate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function actionDeepPageCopyAsTemplate()
    {
        $newItem = null;
        $navId = (int) Yii::$app->request->getBodyParam('navId');
                          Severity: Minor
                          Found in src/admin/apis/NavController.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language