Sign upLogin

luyadev/luya-module-cms

View on GitHub
Star
src/menu/Item.php

Summary

Maintainability
D
2 days
Test Coverage
B
81%

Item has 52 functions (exceeds 20 allowed). Consider refactoring.
Open

class Item extends BaseObject implements LinkInterface, Arrayable
{
    use LinkTrait;
    use ArrayableTrait;
Severity: Major
Found in src/menu/Item.php - About 7 hrs to fix

    File Item.php has 358 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace luya\cms\menu;

use luya\admin\models\User;
    Severity: Minor
    Found in src/menu/Item.php - About 4 hrs to fix

      Function getLink has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getLink()
    {
        // take care of redirect
        if ($this->getType() === 3 && !empty($this->redirectMapData('value'))) {
            // generate convert object to determine correctn usage.
      Severity: Minor
      Found in src/menu/Item.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getLink has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getLink()
    {
        // take care of redirect
        if ($this->getType() === 3 && !empty($this->redirectMapData('value'))) {
            // generate convert object to determine correctn usage.
      Severity: Minor
      Found in src/menu/Item.php - About 1 hr to fix

        Function getKeywords has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getKeywords()
    {
        if ($this->_keywords === null) {
            if (empty($this->itemArray['keywords'])) {
                $this->_keywords = [];
        Severity: Minor
        Found in src/menu/Item.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                            return $converter->getTelephoneLink($converter->value)->getHref();
        Severity: Major
        Found in src/menu/Item.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return Yii::$app->urlManager->prependBaseUrl('');
          Severity: Major
          Found in src/menu/Item.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $link;
            Severity: Major
            Found in src/menu/Item.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return $converter->getFileLink($converter->value, $converter->target)->getHref();
              Severity: Major
              Found in src/menu/Item.php - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function getNextSibling(): \luya\cms\menu\Item|bool
    {
        return (new Query())
            ->where(['parent_nav_id' => $this->parentNavId, 'container' => $this->container])
            ->andWhere(['>', 'sort_index', $this->sortIndex])
                Severity: Minor
                Found in src/menu/Item.php and 1 other location - About 30 mins to fix
                src/menu/Item.php on lines 643..652

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 90.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function getPrevSibling(): \luya\cms\menu\Item|bool
    {
        return (new Query())
            ->where(['parent_nav_id' => $this->parentNavId, 'container' => $this->container])
            ->andWhere(['<', 'sort_index', $this->sortIndex])
                Severity: Minor
                Found in src/menu/Item.php and 1 other location - About 30 mins to fix
                src/menu/Item.php on lines 625..634

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 90.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status