Sign upLogin

luyadev/luya-module-cms

View on GitHub
Star
tests/src/frontend/commands/BlockControllerTest.php

Summary

Maintainability
D
1 day
Test Coverage

Method testModuleBlock has 90 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testModuleBlock()
    {
        $tpl = <<<'EOT'
<?php
Severity: Major
Found in tests/src/frontend/commands/BlockControllerTest.php - About 3 hrs to fix

    Method testAppBlock has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function testAppBlock()
    {
        $tpl = <<<'EOT'
<?php
    Severity: Major
    Found in tests/src/frontend/commands/BlockControllerTest.php - About 3 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              $ctrl->config = [
            'vars' => [
                ['var' => 'foo', 'type' => 'self::TYPE_TEXT', 'label' => 'Foo'],
                ['var' => 'bar', 'type' => 'self::TYPE_IMAGEUPLOAD', 'label' => 'Bar', 'options' => 'OPTIONS!'],
            ],
      Severity: Major
      Found in tests/src/frontend/commands/BlockControllerTest.php and 1 other location - About 3 hrs to fix
      tests/src/frontend/commands/BlockControllerTest.php on lines 281..294

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 142.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              $ctrl->config = [
            'vars' => [
                ['var' => 'foo', 'type' => 'self::TYPE_TEXT', 'label' => 'Foo'],
                ['var' => 'bar', 'type' => 'self::TYPE_IMAGEUPLOAD', 'label' => 'Bar', 'options' => 'OPTIONS!'],
            ],
      Severity: Major
      Found in tests/src/frontend/commands/BlockControllerTest.php and 1 other location - About 3 hrs to fix
      tests/src/frontend/commands/BlockControllerTest.php on lines 139..152

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 142.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status