Sign upLogin

luyadev/luya-module-payment

View on GitHub
Star

Showing 25 of 25 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function actionAbort($lpToken, $lpKey)
    {
        $integrator = $this->module->getIntegrator();
        $model = $integrator->findByKey($lpKey, $lpToken);
Severity: Major
Found in src/frontend/controllers/DefaultController.php and 3 other locations - About 3 hrs to fix
src/frontend/controllers/DefaultController.php on lines 79..101
src/frontend/controllers/DefaultController.php on lines 110..131
src/frontend/controllers/DefaultController.php on lines 142..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 146.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function actionBack($lpToken, $lpKey)
    {
        $integrator = $this->module->getIntegrator();
        $model = $integrator->findByKey($lpKey, $lpToken);
Severity: Major
Found in src/frontend/controllers/DefaultController.php and 3 other locations - About 3 hrs to fix
src/frontend/controllers/DefaultController.php on lines 79..101
src/frontend/controllers/DefaultController.php on lines 142..163
src/frontend/controllers/DefaultController.php on lines 172..193

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 146.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function actionFail($lpToken, $lpKey)
    {
        $integrator = $this->module->getIntegrator();
        $model = $integrator->findByKey($lpKey, $lpToken);
Severity: Major
Found in src/frontend/controllers/DefaultController.php and 3 other locations - About 3 hrs to fix
src/frontend/controllers/DefaultController.php on lines 79..101
src/frontend/controllers/DefaultController.php on lines 110..131
src/frontend/controllers/DefaultController.php on lines 172..193

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 146.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function actionCreate($lpToken, $lpKey)
    {
        $integrator = $this->module->getIntegrator();
        $model = $integrator->findByKey($lpKey, $lpToken);
Severity: Major
Found in src/frontend/controllers/DefaultController.php and 3 other locations - About 3 hrs to fix
src/frontend/controllers/DefaultController.php on lines 110..131
src/frontend/controllers/DefaultController.php on lines 142..163
src/frontend/controllers/DefaultController.php on lines 172..193

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 146.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

PayModel has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

class PayModel extends Model
{
    public $id;
    public $totalAmount;
    public $orderId;
Severity: Minor
Found in src/base/PayModel.php - About 3 hrs to fix

    Transaction has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    abstract class Transaction extends BaseObject
{
    /**
     * Creates the transaction and mostly redirects to the provider afterwards.
     */
    Severity: Minor
    Found in src/base/Transaction.php - About 2 hrs to fix

      Process has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Process extends NgRestModel
{
    public const STATE_PENDING = 0;

    public const STATE_SUCCESS = 1;
      Severity: Minor
      Found in src/models/Process.php - About 2 hrs to fix

        Method create has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function create()
    {
        // handle incoming post requests, with body param or post data.
        if (Yii::$app->request->isPost) {
            Stripe::setApiKey($this->secretKey);
        Severity: Minor
        Found in src/transactions/StripeTransaction.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  fetch(confirmUrl, {
          method: 'POST',
          headers: {
            'Content-Type': 'application/json',
            'X-CSRF-Token': helper.csrfToken()
          Severity: Major
          Found in src/frontend/stripe/src/js/script.js and 1 other location - About 1 hr to fix
          src/frontend/stripe/src/js/script.js on lines 28..41

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              fetch(confirmUrl, {
      method: 'POST',
      headers: {
        'Content-Type': 'application/json',
        'X-CSRF-Token': helper.csrfToken()
          Severity: Major
          Found in src/frontend/stripe/src/js/script.js and 1 other location - About 1 hr to fix
          src/frontend/stripe/src/js/script.js on lines 65..76

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method getCreateModel has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function getCreateModel()
    {
        if ($this->_model) {
            return $this->_model;
        }
          Severity: Minor
          Found in src/Pay.php - About 1 hr to fix

            Method createModel has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function createModel(PayModel $model)
    {
        $process = new Process();
        $process->amount = $model->totalAmount;
        $process->currency = $model->currency;
            Severity: Minor
            Found in src/integrators/DatabaseIntegrator.php - About 1 hr to fix

              Method ngRestActiveWindows has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function ngRestActiveWindows()
    {
        return [
            [
                'class' => DetailViewActiveWindow::class,
              Severity: Minor
              Found in src/models/Process.php - About 1 hr to fix

                Function create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function create()
    {
        // handle incoming post requests, with body param or post data.
        if (Yii::$app->request->isPost) {
            Stripe::setApiKey($this->secretKey);
                Severity: Minor
                Found in src/transactions/StripeTransaction.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method safeUp has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function safeUp()
    {
        $this->createTable('payment_process', [
            'id' => $this->primaryKey(),
            'salt' => $this->string(120)->notNull(),
                Severity: Minor
                Found in src/admin/migrations/m160303_090454_paymentprocess.php - About 1 hr to fix

                  Method addItem has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function addItem($name, $qty, $amount, $totalAmount, $isShipping, $isTax)
                  Severity: Minor
                  Found in src/base/PayModel.php - About 45 mins to fix

                    Consider simplifying this complex logical expression.
                    Open

                            if (empty($this->_orderId) || empty($this->_totalAmount) || empty($this->_currency) || is_null($this->_successLink) || is_null($this->_errorLink) || is_null($this->_abortLink)) {
            throw new PaymentException("orderId, totalAmount, currency, successLink, errorLink and abortLink properties can not be null!");
        }
                    Severity: Major
                    Found in src/Pay.php - About 40 mins to fix

                      Method internalAddItem has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          private function internalAddItem($name, $qty, $amount, $isTax, $isShipping)
                      Severity: Minor
                      Found in src/Pay.php - About 35 mins to fix

                        Function getCreateModel has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                            protected function getCreateModel()
    {
        if ($this->_model) {
            return $this->_model;
        }
                        Severity: Minor
                        Found in src/Pay.php - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Avoid too many return statements within this method.
                        Open

                                    return Yii::$app->view->render('@payment/stripe/layout', [
                'content' => $html,
            ]);
                        Severity: Major
                        Found in src/transactions/StripeTransaction.php - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language