Sign upLogin

luyadev/luya-module-payment

View on GitHub
Star

Showing 25 of 25 total issues

Avoid too many return statements within this method.
Open

        return $this->getContext()->renderContent($html);
Severity: Major
Found in src/transactions/StripeTransaction.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return $this->redirectTransactionFail();
    Severity: Major
    Found in src/transactions/StripeTransaction.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return $this->redirect($model->getApplicationErrorLink());
      Severity: Major
      Found in src/frontend/controllers/DefaultController.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return Yii::$app->view->render('@payment/stripe/layout', [
                'content' => $html,
            ]);
        Severity: Major
        Found in src/transactions/StripeTransaction.php - About 30 mins to fix

          Function assertAndCapture has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function assertAndCapture()
    {
        $data = $this->getIntegrator()->getProviderData($this->getModel());

        if (!isset($data['initialize']['Token'])) {
          Severity: Minor
          Found in src/transactions/SaferPayTransaction.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language