Sign upLogin

luyadev/luya

View on GitHub
Star
core/console/commands/ThemeController.php

Summary

Maintainability
A
4 hrs
Test Coverage
A
100%

Method actionCreate has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function actionCreate(string $themeName = null)
    {
        Console::clearScreenBeforeCursor();

        $themeName = $this->prompt("Enter the name (lower case) of the theme you like to generate:", ['default' => $themeName]);
Severity: Major
Found in core/console/commands/ThemeController.php - About 2 hrs to fix

    Function actionCreate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function actionCreate(string $themeName = null)
    {
        Console::clearScreenBeforeCursor();

        $themeName = $this->prompt("Enter the name (lower case) of the theme you like to generate:", ['default' => $themeName]);
    Severity: Minor
    Found in core/console/commands/ThemeController.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return $this->outputSuccess("Theme files has been created successfully. Please run `".$_SERVER['PHP_SELF']." import` to import the theme into the database.");
    Severity: Major
    Found in core/console/commands/ThemeController.php - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status